Commit 0625260
ADFA-2602: Address review on the asset-zip workflow
Three findings from @jatezzz on #1815:
- The content gate checked seven entries and skipped exactly the two whose
filenames encode the Gradle version, so a constants.kt bump without the
matching createAssetsZip/Asset() rename would publish an 8.14.3 payload to
assets/9.6.1/ with a Slack line claiming 9.6.1 -- the mislabel this PR
exists to prevent. Gate on the interpolated names as well.
- The ~/.ssh/id_rsa hazard the PR body describes spans runs, not just matrix
legs: two overlapping dispatches let one run's Cleanup ssh fire during the
other's scp. Added a top-level concurrency group with
cancel-in-progress: false, since cancelling mid-scp would leave the key and
partial staging on the shared runner.
- The artifact round-trip re-compressed an already-compressed payload and
shipped each leg the other ABI's assets. Measured: the artifact was
1,484,450,451 bytes against ~1,590 MB of input, so compression bought ~6.7%
-- documentation.db does not compress either, because its content blobs are
already brotli-encoded. Now compression-level: 0, and the staging splits
into a common artifact plus one per ABI, so each leg no longer downloads the
other ABI's ~431 MB.
Claude-Session: https://claude.ai/code/session_017HGpMsUzZ5wxCfMtDZ2HGP1 parent 9d74b31 commit 0625260
1 file changed
Lines changed: 45 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
38 | 42 | | |
39 | 43 | | |
40 | 44 | | |
| |||
244 | 248 | | |
245 | 249 | | |
246 | 250 | | |
247 | | - | |
| 251 | + | |
248 | 252 | | |
249 | 253 | | |
250 | | - | |
251 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
252 | 282 | | |
253 | 283 | | |
254 | 284 | | |
| |||
317 | 347 | | |
318 | 348 | | |
319 | 349 | | |
320 | | - | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
321 | 357 | | |
322 | 358 | | |
323 | | - | |
| 359 | + | |
324 | 360 | | |
325 | 361 | | |
326 | 362 | | |
| |||
344 | 380 | | |
345 | 381 | | |
346 | 382 | | |
| 383 | + | |
| 384 | + | |
347 | 385 | | |
348 | 386 | | |
349 | 387 | | |
| |||
352 | 390 | | |
353 | 391 | | |
354 | 392 | | |
355 | | - | |
| 393 | + | |
| 394 | + | |
356 | 395 | | |
357 | 396 | | |
358 | 397 | | |
| |||
0 commit comments