Skip to content

Commit f555227

Browse files
committed
chore: keep the lint group out of make env
`unify` and its `untokenize` dependency are unmaintained; their sdists use `ast.Str.s`, removed in Python 3.12, and neither publishes a wheel. Installing the lint group from `make env` therefore broke the Check Plugin Doc job, which runs on Python 3.14. Move the group into its own `env-lint` target that `lint` and `fix` depend on, so `make env` works on every supported interpreter and only the lint targets need one that can build `unify`.
1 parent 0908464 commit f555227

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

Makefile

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,16 @@ endif
2727

2828
.PHONY: env
2929
env: poetry gen
30-
poetry install --all-extras --with lint
30+
poetry install --all-extras
3131
poetry run pip install --upgrade pip
3232

33+
# The lint group is kept out of `env` on purpose: `unify` (and its `untokenize`
34+
# dependency) are unmaintained and their sdists fail to build on Python >= 3.12,
35+
# so installing them would break `make env` on the newer interpreters.
36+
.PHONY: env-lint
37+
env-lint:
38+
poetry install --only lint
39+
3340
.PHONY: poetry poetry-fallback
3441
# poetry installer may not work on macOS's default python
3542
# falls back to pipx installer
@@ -69,13 +76,13 @@ install: gen-basic
6976

7077
.PHONY: lint
7178
# flake8 configurations should go to the file setup.cfg
72-
lint: clean gen
79+
lint: env-lint clean gen
7380
poetry run flake8 .
7481
poetry run pylint --disable=all --enable=E0602,E0603,E1101 skywalking tests
7582

7683
.PHONY: fix
7784
# fix problems described in CodingStyle.md - verify outcome with extra care
78-
fix:
85+
fix: env-lint
7986
poetry run unify -r --in-place .
8087
poetry run flynt -tc -v .
8188

0 commit comments

Comments
 (0)