You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(ci): repair sw_grpc on grpcio 1.83 and sw_websockets under uvicorn >= 0.50
Both plugin tests have been failing on every master CI run since 88d30ab;
neither failure changes the supported version scope.
- sw_grpc (grpcio == 1.*): grpcio 1.83.0 added an isinstance(x, Channel)
validation in grpc.aio._channel resolved from the module global, which
the plugin had rebound to a factory function -> TypeError on every aio
stub creation. Replace the factory with a Channel subclass; verified
against grpcio 1.83.0 and 1.82.1 with full trace validation.
- sw_websockets (10.3/10.4): uvicorn 0.50.0 (2026-07-04) removed its
legacy websockets fallback and unconditionally imports
websockets.server.ServerProtocol (websockets >= 11 only), so the
unpinned test harness crashed at startup with websockets 10.x. Pin
uvicorn < 0.50 in the test compose; websockets 10.3/10.4 stay tested.
Also extend the support matrix with websockets 17.0.1 (latest), which
passes span validation with the plugin unmodified.
Note: both uvicorn < 0.50's server impl and the plugin's client
instrumentation rest on websockets.legacy (deprecated since websockets
14); when upstream removes it the plugin needs a rewrite against
websockets.asyncio.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
0 commit comments