Fix: pax operator without set null field also should not assert unimplemented sk_strategy

If current operator not support in pax operator. Then the all_null and has_null will
be lost in file level statistics.
Also Pax should not Assert(false) when accept a unimplemented sk_strategy.

Current change also implements the bpchar operator.

Author: jiaqizho

contrib/pax_storage/src/cpp/storage/micro_partition_stats.cc

@@ -78,6 +78,16 @@ void MicroPartitionStats::MergeTo(MicroPartitionStats *stats, TupleDesc desc) {
 
     if (stats->status_[column_index] == 'n' ||
         stats->status_[column_index] == 'x') {
+      // still need update all and has null
+      if (stats_->GetAllNull(column_index) &&
+          !stats->stats_->GetAllNull(column_index)) {
+        stats_->SetAllNull(column_index, false);
+      }
+
+      if (!stats_->GetHasNull(column_index) &&
+          stats->stats_->GetHasNull(column_index)) {
+        stats_->SetHasNull(column_index, true);
+      }
       continue;
     }
 

contrib/pax_storage/src/cpp/storage/oper/pax_oper.cc

@@ -546,6 +546,52 @@ bool TextGT(const void *l, const void *r, Oid collation) {
   return TextCmp(*(const text **)l, *(const text **)r, collation) > 0;
 }
 
+static inline int
+BcTruelen(const BpChar *arg)
+{
+	return bpchartruelen(VARDATA_ANY(arg), VARSIZE_ANY_EXHDR(arg));
+}
+
+bool BpCharLT(const void *l, const void *r, Oid collation) {
+  const BpChar *lbpchar = *(const BpChar **)l;
+  const BpChar *rbpchar = *(const BpChar **)r;
+
+  return VarstrCmp(VARDATA_ANY(lbpchar), BcTruelen(lbpchar), VARDATA_ANY(rbpchar), BcTruelen(rbpchar),
+					 collation) < 0;
+}
+
+bool BpCharLE(const void *l, const void *r, Oid collation) {
+  const BpChar *lbpchar = *(const BpChar **)l;
+  const BpChar *rbpchar = *(const BpChar **)r;
+
+  return VarstrCmp(VARDATA_ANY(lbpchar), BcTruelen(lbpchar), VARDATA_ANY(rbpchar), BcTruelen(rbpchar),
+					 collation) <= 0;
+}
+
+bool BpCharEQ(const void *l, const void *r, Oid collation) {
+  const BpChar *lbpchar = *(const BpChar **)l;
+  const BpChar *rbpchar = *(const BpChar **)r;
+
+  return VarstrCmp(VARDATA_ANY(lbpchar), BcTruelen(lbpchar), VARDATA_ANY(rbpchar), BcTruelen(rbpchar),
+					 collation) == 0;
+}
+
+bool BpCharGE(const void *l, const void *r, Oid collation) {
+  const BpChar *lbpchar = *(const BpChar **)l;
+  const BpChar *rbpchar = *(const BpChar **)r;
+
+  return VarstrCmp(VARDATA_ANY(lbpchar), BcTruelen(lbpchar), VARDATA_ANY(rbpchar), BcTruelen(rbpchar),
+					 collation) >= 0;
+}
+
+bool BpCharGT(const void *l, const void *r, Oid collation) {
+  const BpChar *lbpchar = *(const BpChar **)l;
+  const BpChar *rbpchar = *(const BpChar **)r;
+
+  return VarstrCmp(VARDATA_ANY(lbpchar), BcTruelen(lbpchar), VARDATA_ANY(rbpchar), BcTruelen(rbpchar),
+					 collation) > 0;
+}
+
 }  // namespace textop
 
 namespace numericop {
@@ -755,6 +801,16 @@ std::map<OperMinMaxKey, OperMinMaxFunc> min_max_opers = {
     INIT_MIN_MAX_OPER(TEXTOID, TEXTOID, BTGreaterStrategyNumber,
                       textop::TextGT),
 
+    // oper(bpchar, bpchar)
+    INIT_MIN_MAX_OPER(BPCHAROID, BPCHAROID, BTLessStrategyNumber, textop::BpCharLT),
+    INIT_MIN_MAX_OPER(BPCHAROID, BPCHAROID, BTLessEqualStrategyNumber,
+                      textop::BpCharLE),
+    INIT_MIN_MAX_OPER(BPCHAROID, BPCHAROID, BTEqualStrategyNumber, textop::BpCharEQ),
+    INIT_MIN_MAX_OPER(BPCHAROID, BPCHAROID, BTGreaterEqualStrategyNumber,
+                      textop::BpCharGE),
+    INIT_MIN_MAX_OPER(BPCHAROID, BPCHAROID, BTGreaterStrategyNumber,
+                      textop::BpCharGT),
+
     // oper(numeric, numeric)
     INIT_MIN_MAX_OPER(NUMERICOID, NUMERICOID, BTLessStrategyNumber,
                       numericop::NumericLT),

contrib/pax_storage/src/cpp/storage/oper/pax_oper.h

@@ -23,6 +23,7 @@ extern bool CharLE(const void *l, const void *r, Oid /*collation*/);
 extern bool CharEQ(const void *l, const void *r, Oid /*collation*/);
 extern bool CharGE(const void *l, const void *r, Oid /*collation*/);
 extern bool CharGT(const void *l, const void *r, Oid /*collation*/);
+
 }  // namespace charop
 
 namespace int2op {
@@ -128,6 +129,13 @@ extern bool TextLE(const void *l, const void *r, Oid collation);
 extern bool TextEQ(const void *l, const void *r, Oid collation);
 extern bool TextGE(const void *l, const void *r, Oid collation);
 extern bool TextGT(const void *l, const void *r, Oid collation);
+
+extern bool BpCharLT(const void *l, const void *r, Oid /*collation*/);
+extern bool BpCharLE(const void *l, const void *r, Oid /*collation*/);
+extern bool BpCharEQ(const void *l, const void *r, Oid /*collation*/);
+extern bool BpCharGE(const void *l, const void *r, Oid /*collation*/);
+extern bool BpCharGT(const void *l, const void *r, Oid /*collation*/);
+
 }  // namespace textop
 
 namespace numericop {

contrib/pax_storage/src/cpp/storage/pax_filter.cc

@@ -494,7 +494,7 @@ static bool CheckNonnullValue(const ::pax::stats::ColumnBasicInfo &minmax,
       break;
     }
     default:
-      Assert(false);
+      // not support others `sk_strategy`
       matches = BoolGetDatum(true);
       break;
   }