Skip to content

Commit ba14e49

Browse files
committed
Fix binary swap test failure on PG version bump
The binary swap test compares pg_dump outputs between baseline and current builds using a plain diff. When upgrading the PG kernel minor version (e.g. 14.4 to 14.5), the "-- Dumped from database version" comment line in pg_dump output differs between the two builds, causing a false test failure. Add the `-I` flag with a regex pattern to the diff command in diff_dumps.sql so that comment-only version lines are ignored during comparison. This preserves detection of any real catalog, schema, or data incompatibilities while allowing PG minor version bumps without breaking the binary swap CI check.
1 parent a83ad83 commit ba14e49

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
\! diff dump_other.sql dump_current.sql
1+
\! diff -I '^-- Dumped from database version' dump_other.sql dump_current.sql
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
\! diff dump_other.sql dump_current.sql
1+
\! diff -I '^-- Dumped from database version' dump_other.sql dump_current.sql

0 commit comments

Comments
 (0)