PAX: Change the default catalog to auxiliary table and enable CI

Manifest metadata implementation in PAX is still an experimental
feature. Current commit changes the default catalog implementation
to the auxiliary table implementation.

Also, PAX tests are added to cloudberry's CI

Author: jiaqizho

.asf.yaml

@@ -90,6 +90,10 @@ github:
           - RPM Install Test Apache Cloudberry
           - ic-good-opt-off
           - ic-good-opt-on
+          - pax-ic-good-opt-off
+          - pax-ic-good-opt-on
+          - pax-ic-isolation2-opt-off
+          - pax-ic-isolation2-opt-on
           - ic-expandshrink
           - ic-singlenode
           - ic-resgroup-v2

.github/workflows/build-cloudberry.yml

@@ -230,6 +230,42 @@ jobs:
                "make_configs":["src/test/regress:installcheck-good"],
                "pg_settings":{"optimizer":"on"}
               },
+              {"test":"pax-ic-good-opt-off",
+               "make_configs":[
+                "contrib/pax_storage/:pax-test",
+                "contrib/pax_storage/:regress_test"
+              ],
+               "pg_settings":{
+                 "optimizer":"off",
+                 "default_table_access_method":"pax"
+                }
+              },
+              {"test":"pax-ic-good-opt-on",
+               "make_configs":[
+                "contrib/pax_storage/:pax-test",
+                "contrib/pax_storage/:regress_test"
+              ],
+               "pg_settings":{
+                 "optimizer":"on",
+                 "default_table_access_method":"pax"
+                }
+              },
+              {"test":"pax-ic-isolation2-opt-off",
+               "make_configs":["contrib/pax_storage/:isolation2_test"],
+               "pg_settings":{
+                 "optimizer":"off",
+                 "default_table_access_method":"pax"
+                },
+                "enable_core_check":false
+              },
+              {"test":"pax-ic-isolation2-opt-on",
+               "make_configs":["contrib/pax_storage/:isolation2_test"],
+               "pg_settings":{
+                 "optimizer":"on",
+                 "default_table_access_method":"pax"
+                },
+                "enable_core_check":false
+              },
               {"test":"ic-expandshrink",
                "make_configs":["src/test/isolation2:installcheck-expandshrink"]
               },
@@ -482,6 +518,11 @@ jobs:
         run: |
           set -eo pipefail
 
+          if ! time su - gpadmin -c "cd ${SRC_DIR} && git submodule update --init"; then
+            echo "::error::Fail to pull submodule."
+            exit 1
+          fi
+
           chmod +x "${SRC_DIR}"/../cloudberry-devops-release/build_automation/cloudberry/scripts/build-cloudberry.sh
           if ! time su - gpadmin -c "cd ${SRC_DIR} && SRC_DIR=${SRC_DIR} ${SRC_DIR}/../cloudberry-devops-release/build_automation/cloudberry/scripts/build-cloudberry.sh"; then
             echo "::error::Build script failed"
@@ -1267,6 +1308,10 @@ jobs:
             PG_OPTS="$PG_OPTS -c optimizer=${{ matrix.pg_settings.optimizer }}"
           fi
 
+          if [[ "${{ matrix.pg_settings.default_table_access_method != '' }}" == "true" ]]; then
+            PG_OPTS="$PG_OPTS -c default_table_access_method=${{ matrix.pg_settings.default_table_access_method }}"
+          fi
+
           # Read configs into array
           IFS=' ' read -r -a configs <<< "${{ join(matrix.make_configs, ' ') }}"
 

.github/workflows/build-dbg-cloudberry.yml

@@ -427,6 +427,11 @@ jobs:
         run: |
           set -eo pipefail
 
+          if ! time su - gpadmin -c "cd ${SRC_DIR} && git submodule update --init"; then
+            echo "::error::Fail to pull submodule."
+            exit 1
+          fi
+
           chmod +x "${SRC_DIR}"/../cloudberry-devops-release/build_automation/cloudberry/scripts/build-cloudberry.sh
           if ! time su - gpadmin -c "cd ${SRC_DIR} && SRC_DIR=${SRC_DIR} ${SRC_DIR}/../cloudberry-devops-release/build_automation/cloudberry/scripts/build-cloudberry.sh"; then
             echo "::error::Build script failed"

configure

@@ -9124,11 +9124,11 @@ $as_echo "#define USE_PAX_STORAGE 1" >>confdefs.h
   esac
 
 else
-  enable_pax=no
-
+  enable_pax=yes
+  
+  $as_echo "#define USE_PAX_STORAGE 1" >>confdefs.h
 fi
 
-
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: checking whether to build with pax support ... $enable_pax" >&5
 $as_echo "checking whether to build with pax support ... $enable_pax" >&6; }
 

configure.ac

@@ -928,11 +928,11 @@ AC_SUBST(enable_preload_ic_module)
 #
 # pax support
 #
-PGAC_ARG_BOOL(enable, pax, no,
-              [enable pax support],
+PGAC_ARG_BOOL(enable, pax, yes,
+              [disable PAX support],
               [AC_DEFINE(USE_PAX_STORAGE, 1,
-                         [Define to 1 to support pax])])
-AC_MSG_RESULT([checking whether to build with pax support ... $enable_pax])
+                         [Define to 1 to support PAX])])
+AC_MSG_RESULT([checking whether to build with PAX support ... $enable_pax])
 AC_SUBST(enable_pax)
 
 #

contrib/pax_storage/.gitmodules

@@ -8,15 +8,15 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Werror -Wno-unused-function -Wno-redundant-move -Wno-error=redundant-move -Wno-error=ignored-qualifiers -Wuninitialized -Winit-self -Wstrict-aliasing -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered -Wno-sized-deallocation -g")
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wno-unused-parameter -Wno-parameter-name")
 
-option(USE_MANIFEST_API "Use manifest API" ON)
-option(USE_PAX_CATALOG "Use manifest API, by pax impl" OFF)
+option(USE_MANIFEST_API "Use manifest API" OFF)
+option(USE_PAX_CATALOG "Use manifest API, by pax impl" ON)
 
 # Build gtest options
 option(BUILD_GTEST "Build with google test" ON)
 option(BUILD_GBENCH "Build with google benchmark" ON)
 
 # Build pax tools
-option(BUILD_TOOLS "Build with pax tools" ON)
+option(BUILD_TOOLS "Build with pax tools" OFF)
 
 # Build with return dictionary in record batch
 option(BUILD_RB_RET_DICT "Build with pax direct return dictionary in record batch." OFF)

contrib/pax_storage/CMakeLists.txt

@@ -39,11 +39,11 @@ USE_PAX_CATALOG := $(shell echo $$USE_PAX_CATALOG)
 
 # if the ENVs are not set, set default value
 ifeq ($(USE_MANIFEST_API),)
-    USE_MANIFEST_API := ON
+    USE_MANIFEST_API := OFF
 endif
 
 ifeq ($(USE_PAX_CATALOG),)
-    USE_PAX_CATALOG := OFF
+    USE_PAX_CATALOG := ON
 endif
 
 .PHONY: install-data build