Skip to content

Commit 980a7bd

Browse files
tglsfdcrobozmey
authored andcommitted
In pg_dump, use simplehash.h to look up dumpable objects by OID.
Backported from PG15 92316a4 Conflicts resolved: * Move GPDB specific numTypeStorageOptions to getSchemaData function * Refactor getTypeStorageOptions query to return tableoid and oid fields, which are required to correctly index the hash table Original commit message follows: Create a hash table that indexes dumpable objects by CatalogId (that is, catalog OID + object OID). Use this to replace the former catalogIdMap array, as well as various other single- catalog index arrays, and also the extension membership map. In principle this should be faster for databases with many objects, since lookups are now O(1) not O(log N). However, it seems that these lookups are pretty much negligible in context, so that no overall performance change can be measured. But having only one lookup data structure to maintain makes the code simpler and more flexible, so let's do it anyway. Discussion: https://postgr.es/m/2595220.1634855245@sss.pgh.pa.us
1 parent c31e9bd commit 980a7bd

4 files changed

Lines changed: 227 additions & 347 deletions

File tree

0 commit comments

Comments
 (0)