Skip to content

Commit 6759bf7

Browse files
committed
Remove heap_fetch_extended function.
Sync src/backend/access/heap/heapam.c internals with upstream. heap_fetch_extended introudced postgres/postgres@c590e51 as back-paches fix from HEAD. There is no point to keep this function after postgresql-16 merge
1 parent 477e86e commit 6759bf7

2 files changed

Lines changed: 0 additions & 22 deletions

File tree

src/backend/access/heap/heapam.c

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1424,25 +1424,6 @@ heap_fetch(Relation relation,
14241424
HeapTuple tuple,
14251425
Buffer *userbuf,
14261426
bool keep_buf)
1427-
{
1428-
return heap_fetch_extended(relation, snapshot, tuple, userbuf, false);
1429-
}
1430-
1431-
/*
1432-
* heap_fetch_extended - fetch tuple even if it fails snapshot test
1433-
*
1434-
* If keep_buf is true, then upon finding a tuple that is valid but fails
1435-
* the snapshot check, we return the tuple pointer in tuple->t_data and the
1436-
* buffer ID in *userbuf, keeping the buffer pin, just as if it had passed
1437-
* the snapshot. (The function result is still "false" though.)
1438-
* If keep_buf is false then this behaves identically to heap_fetch().
1439-
*/
1440-
bool
1441-
heap_fetch_extended(Relation relation,
1442-
Snapshot snapshot,
1443-
HeapTuple tuple,
1444-
Buffer *userbuf,
1445-
bool keep_buf)
14461427
{
14471428
ItemPointer tid = &(tuple->t_self);
14481429
ItemId lp;

src/include/access/heapam.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,6 @@ extern bool heap_getnextslot_tidrange(TableScanDesc sscan,
229229
extern uint32 heap_scan_flags(Relation relation);
230230
extern bool heap_fetch(Relation relation, Snapshot snapshot,
231231
HeapTuple tuple, Buffer *userbuf, bool keep_buf);
232-
extern bool heap_fetch_extended(Relation relation, Snapshot snapshot,
233-
HeapTuple tuple, Buffer *userbuf,
234-
bool keep_buf);
235232
extern bool heap_hot_search_buffer(ItemPointer tid, Relation relation,
236233
Buffer buffer, Snapshot snapshot, HeapTuple heapTuple,
237234
bool *all_dead, bool first_call);

0 commit comments

Comments
 (0)