Fix gpcheckcat that checks foreign key reference for appendonly tables

As greenplum-db/gpdb-archive@afde39b3f973c
committed in Greenplum upstream, the partition table allows to have
table access method.

One additional behavior is that the normal appendonly tables have
their entries in pg_appendonly, one-per-entry. But the partition
table hasn't. The foreign key check is applied. Missing entry in
pg_appendonly for tables with relam to be ao_row/ao_column will
be reported in gpcheckcat.

This commit backports partial changes from the above commit,
and will fix the catalog issue.

Author: gfphoenix78

gpMgmt/bin/gpcheckcat_modules/foreign_key_check.py

@@ -15,7 +15,7 @@ def __init__(self, db_connection, logger, shared_option, autoCast):
         self.shared_option = shared_option
         self.autoCast = autoCast
         self.query_filters = dict()
-        self.query_filters['pg_appendonly.relid'] = "(select amname from pg_am am where am.oid = relam) IN ('ao_row', 'ao_column')"
+        self.query_filters['pg_appendonly.relid'] = "((select amname from pg_am am where am.oid = relam) IN ('ao_row', 'ao_column')) AND relkind != 'p'"
         self.query_filters['pg_attribute.attrelid'] = "(relnatts > 0 or relnatts is NULL)"
         self.query_filters["pg_index.indexrelid"] = "(relkind='i')"
 

gpMgmt/bin/gppylib/test/unit/test_unit_foreign_key_check.py

@@ -175,7 +175,7 @@ def __generate_pg_class_call(table, primary_key_cat_name, col_type, with_filter=
     ####################### PRIVATE METHODS #######################
     def _get_filter(self, table_name):
         query_filters = {}
-        query_filters['pg_appendonly'] = "(select amname from pg_am am where am.oid = relam) IN ('ao_row', 'ao_column')"
+        query_filters['pg_appendonly'] = "((select amname from pg_am am where am.oid = relam) IN ('ao_row', 'ao_column')) AND relkind != 'p'"
         query_filters['pg_attribute'] = "(relnatts > 0 or relnatts is NULL)"
         query_filters['pg_constraint'] = "((relchecks>0 or relhaspkey='t') and relkind = 'r')"
         query_filters['gp_distribution_policy'] = """(relnamespace not in(select oid from pg_namespace where nspname ~ 'pg_')