Remove unneccesary version checks from pg_dump

Upstream has removed support for server versions older than 9.2.[1]

The motivation for `error_unsupported_server_version`
was to reduce diff footprint when upstream supported much older
versions.[2]

We still need to support GPDB5 (PostgreSQL 8.3), so
remove version checks for PostgreSQL 8.2 and below.

1: postgres/postgres@30e7c17
2: bmdoil/gpdb@b4c5a61

Authored-by: Brent Doil <bdoil@vmware.com>

Author: robozmey

src/bin/pg_dump/common.c

@@ -186,11 +186,8 @@ getSchemaData(Archive *fout, int *numTablesPtr)
 	oprinfo = getOperators(fout, &numOperators);
 	oprinfoindex = buildIndexArray(oprinfo, numOperators, sizeof(OprInfo));
 
-	if (testExtProtocolSupport(fout))
-	{
-		pg_log_info("reading user-defined external protocols");
-		getExtProtocols(fout, &numExtProtocols);
-	}
+	pg_log_info("reading user-defined external protocols");
+	getExtProtocols(fout, &numExtProtocols);
 
 	pg_log_info("reading user-defined access methods");
 	getAccessMethods(fout, &numAccessMethods);

src/bin/pg_dump/dumputils.c

@@ -194,20 +194,6 @@ buildACLCommands(const char *name, const char *subname, const char *nspname,
 		}
 	}
 
-	/*
-	 * We still need some hacking though to cover the case where new default
-	 * public privileges are added in new versions: the REVOKE ALL will revoke
-	 * them, leading to behavior different from what the old version had,
-	 * which is generally not what's wanted.  So add back default privs if the
-	 * source database is too old to have had that particular priv.
-	 */
-	if (remoteVersion < 80200 && strcmp(type, "DATABASE") == 0)
-	{
-		/* database CONNECT priv didn't exist before 8.2 */
-		appendPQExpBuffer(firstsql, "%sGRANT CONNECT ON %s %s TO PUBLIC;\n",
-						  prefix, type, name);
-	}
-
 	/* Scan individual ACL items */
 	for (i = 0; i < naclitems; i++)
 	{