From 17bd59d3f5cf42489464baf8f786d576d3e3e3e0 Mon Sep 17 00:00:00 2001 From: vil02 <65706193+vil02@users.noreply.github.com> Date: Wed, 1 Oct 2025 12:16:45 +0200 Subject: [PATCH] Define empty destructors using `default` Types with user defined destructors (even empty) are not trivially destructible. This change allows further compiler optimizations. --- include/CXXGraph/Partitioning/CoordinatedPartitionState.hpp | 2 +- include/CXXGraph/Partitioning/EBV.hpp | 2 +- include/CXXGraph/Partitioning/EdgeBalancedVertexCut.hpp | 2 +- include/CXXGraph/Partitioning/GreedyVertexCut.hpp | 2 +- include/CXXGraph/Partitioning/HDRF.hpp | 2 +- include/CXXGraph/Partitioning/PartitionerThread.hpp | 2 +- include/CXXGraph/Partitioning/Utility/Globals.hpp | 2 +- include/CXXGraph/Partitioning/WeightBalancedLibra.hpp | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/CXXGraph/Partitioning/CoordinatedPartitionState.hpp b/include/CXXGraph/Partitioning/CoordinatedPartitionState.hpp index ed07e12fa..ef972a4a4 100644 --- a/include/CXXGraph/Partitioning/CoordinatedPartitionState.hpp +++ b/include/CXXGraph/Partitioning/CoordinatedPartitionState.hpp @@ -104,7 +104,7 @@ CoordinatedPartitionState::CoordinatedPartitionState(const Globals &G) } template -CoordinatedPartitionState::~CoordinatedPartitionState() {} +CoordinatedPartitionState::~CoordinatedPartitionState() = default; template std::shared_ptr> CoordinatedPartitionState::getRecord( diff --git a/include/CXXGraph/Partitioning/EBV.hpp b/include/CXXGraph/Partitioning/EBV.hpp index eb6d1b012..d8a7c025d 100644 --- a/include/CXXGraph/Partitioning/EBV.hpp +++ b/include/CXXGraph/Partitioning/EBV.hpp @@ -65,7 +65,7 @@ EBV::EBV(const Globals &G) : GLOBALS(G) { // this->GLOBALS = G; } template -EBV::~EBV() {} +EBV::~EBV() = default; template void EBV::performStep(shared> e, shared> state) { diff --git a/include/CXXGraph/Partitioning/EdgeBalancedVertexCut.hpp b/include/CXXGraph/Partitioning/EdgeBalancedVertexCut.hpp index 4a9096678..50270d441 100644 --- a/include/CXXGraph/Partitioning/EdgeBalancedVertexCut.hpp +++ b/include/CXXGraph/Partitioning/EdgeBalancedVertexCut.hpp @@ -63,7 +63,7 @@ EdgeBalancedVertexCut::EdgeBalancedVertexCut(const Globals &G) : GLOBALS(G) { // this->GLOBALS = G; } template -EdgeBalancedVertexCut::~EdgeBalancedVertexCut() {} +EdgeBalancedVertexCut::~EdgeBalancedVertexCut() = default; template void EdgeBalancedVertexCut::performStep(shared> e, shared> state) { diff --git a/include/CXXGraph/Partitioning/GreedyVertexCut.hpp b/include/CXXGraph/Partitioning/GreedyVertexCut.hpp index c76dc73aa..e58ae99b7 100644 --- a/include/CXXGraph/Partitioning/GreedyVertexCut.hpp +++ b/include/CXXGraph/Partitioning/GreedyVertexCut.hpp @@ -65,7 +65,7 @@ template GreedyVertexCut::GreedyVertexCut(const Globals &G) : GLOBALS(G) {} template -GreedyVertexCut::~GreedyVertexCut() {} +GreedyVertexCut::~GreedyVertexCut() = default; template void GreedyVertexCut::performStep(shared> e, diff --git a/include/CXXGraph/Partitioning/HDRF.hpp b/include/CXXGraph/Partitioning/HDRF.hpp index cd9e6bbd7..6f363c269 100644 --- a/include/CXXGraph/Partitioning/HDRF.hpp +++ b/include/CXXGraph/Partitioning/HDRF.hpp @@ -65,7 +65,7 @@ HDRF::HDRF(const Globals &G) : GLOBALS(G) { // this->GLOBALS = G; } template -HDRF::~HDRF() {} +HDRF::~HDRF() = default; template void HDRF::performStep(shared> e, shared> state) { diff --git a/include/CXXGraph/Partitioning/PartitionerThread.hpp b/include/CXXGraph/Partitioning/PartitionerThread.hpp index f3b09615e..9f8e2959c 100644 --- a/include/CXXGraph/Partitioning/PartitionerThread.hpp +++ b/include/CXXGraph/Partitioning/PartitionerThread.hpp @@ -58,7 +58,7 @@ PartitionerThread::PartitionerThread( this->algorithm = algorithm; } template -PartitionerThread::~PartitionerThread() {} +PartitionerThread::~PartitionerThread() = default; template void PartitionerThread::run() { for (const auto &edge_it : list) { diff --git a/include/CXXGraph/Partitioning/Utility/Globals.hpp b/include/CXXGraph/Partitioning/Utility/Globals.hpp index 1f12c67f9..c031cac79 100755 --- a/include/CXXGraph/Partitioning/Utility/Globals.hpp +++ b/include/CXXGraph/Partitioning/Utility/Globals.hpp @@ -72,7 +72,7 @@ inline Globals::Globals(const int numberOfPartiton, } } -inline Globals::~Globals() {} +inline Globals::~Globals() = default; inline const std::string Globals::print() const { std::string prt_str; diff --git a/include/CXXGraph/Partitioning/WeightBalancedLibra.hpp b/include/CXXGraph/Partitioning/WeightBalancedLibra.hpp index 284454f4f..2f6a2e6cf 100644 --- a/include/CXXGraph/Partitioning/WeightBalancedLibra.hpp +++ b/include/CXXGraph/Partitioning/WeightBalancedLibra.hpp @@ -61,7 +61,7 @@ WeightBalancedLibra::WeightBalancedLibra( weight_sum_bound(_weight_sum_bound), vertices_degrees(_vertices_degrees) {} template -WeightBalancedLibra::~WeightBalancedLibra() {} +WeightBalancedLibra::~WeightBalancedLibra() = default; template void WeightBalancedLibra::performStep(shared> e, shared> state) {