General performance improvement and BFS optimizzation

Author: ZigRazor

include/CXXGraph/Graph/Algorithm/BreadthFirstSearch_impl.hpp

@@ -33,30 +33,33 @@ const std::vector<Node<T>> Graph<T>::breadth_first_search(
     const Node<T> &start) const {
   // vector to keep track of visited nodes
   std::vector<Node<T>> visited;
-  auto &nodeSet = Graph<T>::getNodeSet();
+  // std::unordered_set<CXXGraph::id_t> visited_ids;
+
   // check is exist node in the graph
-  auto start_node_it = std::find_if(
-      nodeSet.begin(), nodeSet.end(),
-      [&start](auto &node) { return node->getUserId() == start.getUserId(); });
-  if (start_node_it == nodeSet.end()) {
+
+  auto start_node = Graph<T>::getNode(start.getId());
+  if (!start_node.has_value()) {
     return visited;
   }
   // queue that stores vertices that need to be further explored
   std::queue<shared<const Node<T>>> tracker;
 
   // mark the starting node as visited
   visited.push_back(start);
-  tracker.push(*start_node_it);
+  // visited_ids.insert(start.getId());
+  tracker.push(start_node.value());
   while (!tracker.empty()) {
     shared<const Node<T>> node = tracker.front();
     tracker.pop();
     if (cachedAdjListOut->find(node) != cachedAdjListOut->end()) {
       for (const auto &elem : cachedAdjListOut->at(node)) {
-        // if the node is not visited then mark it as visited
-        // and push it to the queue
-        if (std::find(visited.begin(), visited.end(), *(elem.first)) ==
-            visited.end()) {
+        if (std::find_if(visited.begin(), visited.end(),
+                         [&elem](const auto &node) {
+                           return node.getId() == elem.first->getId();
+                         }) == visited.end()) {
+          // if (visited_ids.find(elem.first->getId()) == visited_ids.end()) {
           visited.push_back(*(elem.first));
+          // visited_ids.insert(elem.first->getId());
           tracker.push(elem.first);
         }
       }

include/CXXGraph/Graph/Graph_impl.hpp

@@ -481,10 +481,13 @@ void Graph<T>::setNodeData(std::map<std::string, T> &dataMap) {
 template <typename T>
 const std::optional<shared<const Edge<T>>> Graph<T>::getEdge(
     const std::string &edgeUserId) const {
-  for (const auto &it : edgeSet) {
-    if (it->getUserId() == edgeUserId) {
-      return it;
-    }
+  const auto &edgeSet = this->getEdgeSet();
+  auto it = std::find_if(edgeSet.begin(), edgeSet.end(),
+                         [&edgeUserId](const auto &edge) {
+                           return edge->getUserId() == edgeUserId;
+                         });
+  if (it != edgeSet.end()) {
+    return *it;
   }
 
   return std::nullopt;
@@ -493,10 +496,12 @@ const std::optional<shared<const Edge<T>>> Graph<T>::getEdge(
 template <typename T>
 const std::optional<shared<const Edge<T>>> Graph<T>::getEdge(
     const CXXGraph::id_t edgeId) const {
-  for (const auto &it : edgeSet) {
-    if (it->getId() == edgeId) {
-      return it;
-    }
+  const auto &edgeSet = this->getEdgeSet();
+  auto it = std::find_if(
+      edgeSet.begin(), edgeSet.end(),
+      [edgeId](const auto &edge) { return edge->getId() == edgeId; });
+  if (it != edgeSet.end()) {
+    return *it;
   }
 
   return std::nullopt;
@@ -505,10 +510,13 @@ const std::optional<shared<const Edge<T>>> Graph<T>::getEdge(
 template <typename T>
 const std::optional<shared<const Node<T>>> Graph<T>::getNode(
     const std::string &nodeUserId) const {
-  for (const auto &it : getNodeSet()) {
-    if (it->getUserId() == nodeUserId) {
-      return it;
-    }
+  const auto &nodeSet = this->getNodeSet();
+  auto it = std::find_if(nodeSet.begin(), nodeSet.end(),
+                         [&nodeUserId](const auto &node) {
+                           return node->getUserId() == nodeUserId;
+                         });
+  if (it != nodeSet.end()) {
+    return *it;
   }
 
   return std::nullopt;
@@ -517,10 +525,12 @@ const std::optional<shared<const Node<T>>> Graph<T>::getNode(
 template <typename T>
 const std::optional<shared<const Node<T>>> Graph<T>::getNode(
     const CXXGraph::id_t nodeId) const {
-  for (const auto &it : getNodeSet()) {
-    if (it->getId() == nodeId) {
-      return it;
-    }
+  const auto &nodeSet = this->getNodeSet();
+  auto it = std::find_if(
+      nodeSet.begin(), nodeSet.end(),
+      [nodeId](const auto &node) { return node->getId() == nodeId; });
+  if (it != nodeSet.end()) {
+    return *it;
   }
 
   return std::nullopt;
@@ -538,7 +548,7 @@ std::unordered_set<shared<Node<T>>, nodeHash<T>> Graph<T>::nodeSet() {
     nodeSet.insert(std::const_pointer_cast<Node<T>>(adjListOutIt.first));
   }
 
-  for (auto &isNodeIt : isolatedNodesSet) {
+  for (const auto &isNodeIt : isolatedNodesSet) {
     nodeSet.insert(std::const_pointer_cast<Node<T>>(isNodeIt));
   }