Skip to content

Commit a60483f

Browse files
committed
Attempts to fix failing test
Joins all threads instead of only joining joinable ones
1 parent 57c1ee6 commit a60483f

2 files changed

Lines changed: 3 additions & 14 deletions

File tree

.github/workflows/cmake.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ jobs:
5656
working-directory: ${{github.workspace}}/build/test
5757
# Execute tests defined by the CMake configuration.
5858
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
59-
run: ctest
59+
run: ctest --output-on-failure
6060

include/CXXGraph/Partitioning/Partitioner.hpp

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -192,20 +192,9 @@ CoordinatedPartitionState<T> Partitioner<T>::startCoordinated() {
192192
}
193193
}
194194
for (int t = 0; t < processors; ++t) {
195-
if (myThreads[t].joinable()) {
196-
myThreads[t].join();
197-
}
198-
// if(myRunnable[t] != nullptr){
199-
// delete myRunnable[t];
200-
//}
201-
}
202-
/*
203-
for (int t = 0; t < processors; ++t){
204-
if (runnableList[t] != nullptr){
205-
delete runnableList[t];
206-
}
195+
myThreads[t].join();
207196
}
208-
*/
197+
209198
// new shared state is move constructed then returned
210199
// (so has no effect on the shared ponter)
211200
return std::move(*shared_state);

0 commit comments

Comments
 (0)