Skip to content

Commit 15eaeab

Browse files
authored
Make some global variables const (#531)
This change resolves all of the cppcoreguidelines-avoid-non-const-global-variables warnings.
1 parent 183dec2 commit 15eaeab

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

benchmark/Utilities.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ static CXXGraph::Graph<int> *readGraph(const std::string &filename) {
8383

8484
// Static Generation
8585

86-
static auto nodes = generateRandomNodes(100000, 2);
87-
static auto edges = generateRandomEdges(100000, nodes);
88-
static auto undirectedEdges = generateRandomUndirectedEdges(100000, nodes);
89-
static auto cit_graph_ptr = readGraph("CitHepPh");
86+
static const auto nodes = generateRandomNodes(100000, 2);
87+
static const auto edges = generateRandomEdges(100000, nodes);
88+
static const auto undirectedEdges = generateRandomUndirectedEdges(100000, nodes);
89+
static const auto cit_graph_ptr = readGraph("CitHepPh");
9090

9191
#endif // __UTILITIES_H__

examples/PartitionExample/partition_example.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ static CXXGraph::Graph<int> *readGraph(const std::string &filename) {
1313
return graph_ptr;
1414
}
1515

16-
static auto cit_graph_ptr = readGraph("CitHepPh");
16+
static const auto cit_graph_ptr = readGraph("CitHepPh");
1717

1818
int main() {
1919
// std::cout << *cit_graph_ptr << std::endl;

test/PartitionTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ using shared = std::shared_ptr<T>;
1313
using std::make_shared;
1414
using std::make_unique;
1515

16-
static auto nodes = generateRandomNodes(10000, 2);
17-
static auto edges = generateRandomEdges(10000, nodes);
16+
static const auto nodes = generateRandomNodes(10000, 2);
17+
static const auto edges = generateRandomEdges(10000, nodes);
1818

1919
TEST(PartitionTest, test_1) {
2020
CXXGraph::Node<int> node1("1", 1);

test/RWOutputTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ generateRandomEdges(
5252
return edges;
5353
}
5454

55-
static auto nodes = generateRandomNodes(10000, 2);
56-
static auto edges = generateRandomEdges(10000, nodes);
55+
static const auto nodes = generateRandomNodes(10000, 2);
56+
static const auto edges = generateRandomEdges(10000, nodes);
5757

5858
//************* CSV ***************//
5959

0 commit comments

Comments
 (0)