List is already covariant in Kotlin (List<out E>), so List<out ABCClass> is redundant; List<ABCClass> is enough.

Author: aschenzle

core/src/main/kotlin/org/evomaster/core/mongo/MongoDbAction.kt

@@ -58,11 +58,11 @@ class MongoDbAction(
         return "MONGO_Insert_${database}_${collection}_${documentsType}"
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
         return genes
     }
 
     override fun copyContent(): Action {
         return MongoDbAction(database, collection, documentsType, genes.map(Gene::copy))
     }
-}
+}

core/src/main/kotlin/org/evomaster/core/problem/externalservice/HostnameResolutionAction.kt

@@ -50,7 +50,7 @@ class HostnameResolutionAction(
         return "Hostname_${hostname}_${localIPAddress}"
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
         return listOf()
     }
 

core/src/main/kotlin/org/evomaster/core/problem/externalservice/httpws/HttpExternalServiceAction.kt

@@ -75,7 +75,7 @@ class HttpExternalServiceAction(
             (response.responseBody.gene as StringGene).forceTaintedValue()
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
         return response.genes
     }
 

core/src/main/kotlin/org/evomaster/core/problem/externalservice/rpc/DbAsExternalServiceAction.kt

@@ -50,7 +50,7 @@ class DbAsExternalServiceAction (
         return getDbAsExternalServiceAction(commandName, requestRuleIdentifier, (response as ClassResponseParam).className)
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
         return response.genes
     }
 

core/src/main/kotlin/org/evomaster/core/problem/externalservice/rpc/RPCExternalServiceAction.kt

@@ -59,7 +59,7 @@ class RPCExternalServiceAction(
         return getRPCExternalServiceActionName(interfaceName, functionName, requestRuleIdentifier, (response as ClassResponseParam).className)
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
         return response.genes
     }
 

core/src/main/kotlin/org/evomaster/core/problem/graphql/GraphQLAction.kt

@@ -27,7 +27,7 @@ class GraphQLAction(
         return "$methodName"
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
 
         return parameters.flatMap { it.seeGenes() }
     }
@@ -42,4 +42,4 @@ class GraphQLAction(
     override fun toString(): String {
         return "$methodType $methodName, auth=${auth.name}"
     }
-}
+}

core/src/main/kotlin/org/evomaster/core/problem/rest/data/RestCallAction.kt

@@ -158,7 +158,7 @@ class RestCallAction(
         return "$verb:$path"
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
         return parameters.flatMap { it.seeGenes() }
     }
 

core/src/main/kotlin/org/evomaster/core/problem/rest/resource/RestResourceCalls.kt

@@ -194,7 +194,7 @@ class RestResourceCalls(
     /**
      * @return actions with specified action [filter]
      */
-    fun seeActions(filter: ActionFilter): List<out Action> {
+    fun seeActions(filter: ActionFilter): List<Action> {
         return when (filter) {
             ActionFilter.ALL -> sqlActions.plus(externalServiceActions).plus(mainActions) // FIXME: Is this correct?
             ActionFilter.INIT -> sqlActions.plus(mongoDbActions).plus(redisDbActions).plus(dnsActions)
@@ -254,7 +254,7 @@ class RestResourceCalls(
      * @return the mutable SQL genes and they do not bind with any of Rest Actions
      *
      * */
-    private fun seeMutableSQLGenes(): List<out Gene> = getResourceNode()
+    private fun seeMutableSQLGenes(): List<Gene> = getResourceNode()
         .getMutableSQLGenes(sqlActions, getRestTemplate(), is2POST)
 
 

core/src/main/kotlin/org/evomaster/core/problem/rest/resource/RestResourceNode.kt

@@ -166,7 +166,7 @@ open class RestResourceNode(
     /**
      * @return mutable genes in [dbactions] and they do not bind with rest actions.
      */
-    fun getMutableSQLGenes(dbactions: List<SqlAction>, template: String, is2POST : Boolean) : List<out Gene>{
+    fun getMutableSQLGenes(dbactions: List<SqlAction>, template: String, is2POST : Boolean) : List<Gene>{
 
         val related = getPossiblyBoundParams(template, is2POST, null).map {
             resourceToTable.paramToTable[it.key]
@@ -182,7 +182,7 @@ open class RestResourceNode(
      * @return mutable genes in [actions] which perform action on current [this] resource node
      *          with [callsTemplate] template, e.g., POST-GET
      */
-    private fun getMutableRestGenes(actions: List<RestCallAction>, template: String) : List<out Gene>{
+    private fun getMutableRestGenes(actions: List<RestCallAction>, template: String) : List<Gene>{
 
         if (!RestResourceTemplateHandler.isNotSingleAction(template)) return actions.flatMap(RestCallAction::seeTopGenes).filter(Gene::isMutable)
 

core/src/main/kotlin/org/evomaster/core/problem/rpc/RPCCallAction.kt

@@ -44,7 +44,7 @@ open class RPCCallAction(
         return id
     }
 
-    override fun seeTopGenes(): List<out Gene> {
+    override fun seeTopGenes(): List<Gene> {
         // ignore genes in response here
         return parameters.flatMap { it.seeGenes() }
     }