Another attempt to mark the job as yellow if warnings/errors increased

Author: aschenzle

.github/actions/full-build-metrics/action.yml

@@ -23,6 +23,11 @@ inputs:
     required: false
     default: "90"
 
+outputs:
+  regression:
+    description: Whether warnings/errors increased versus baseline
+    value: ${{ steps.count.outputs.regression }}
+
 runs:
   using: composite
   steps:
@@ -37,6 +42,7 @@ runs:
         if_no_artifact_found: warn
 
     - name: Count warnings/errors and compare
+      id: count
       shell: bash
       run: |
         if [ -f "${{ inputs.log-file }}" ]; then
@@ -89,11 +95,7 @@ runs:
           fi
         } >> "$GITHUB_STEP_SUMMARY"
 
-        if [ "${regression}" = "true" ]; then
-          echo "METRICS_REGRESSION=true" >> "$GITHUB_ENV"
-        else
-          echo "METRICS_REGRESSION=false" >> "$GITHUB_ENV"
-        fi
+        echo "regression=${regression}" >> "$GITHUB_OUTPUT"
 
     - name: Upload current metrics artifact
       uses: actions/upload-artifact@v7
@@ -103,9 +105,3 @@ runs:
         retention-days: ${{ inputs.retention-days }}
         if-no-files-found: error
 
-    - name: Mark metrics regression
-      shell: bash
-      run: |
-        if [ "${METRICS_REGRESSION:-false}" = "true" ]; then
-          exit 1
-        fi

.github/workflows/ci.yml

@@ -164,7 +164,7 @@ jobs:
           name: full-build-base-log-current
           path: .
       - name: Analyze and persist full-build-base metrics
-        continue-on-error: true
+        id: metrics
         uses: ./.github/actions/full-build-metrics
         with:
           log-file: full-build-base.log
@@ -173,6 +173,12 @@ jobs:
           workflow-file: ci.yml
           #These metrics occupy very little space, increasing the retention so they are not lost if nothing is merged to master in a while
           retention-days: 90
+      - name: Mark metrics regression
+        if: steps.metrics.outputs.regression == 'true'
+        continue-on-error: true
+        run: |
+          echo "::warning::Warnings/errors increased versus baseline."
+          exit 1
 
   base-build-mac:
     runs-on: macos-latest