Skip to content

Commit 86b4d9d

Browse files
committed
better errors handling
1 parent df1ddb2 commit 86b4d9d

5 files changed

Lines changed: 20 additions & 10 deletions

File tree

modules/wljs-editor/dist/kernel.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40047,10 +40047,12 @@ const uuidv4$4 = () => {
4004740047
const errBox$1 = (span, self, err) => {
4004840048
self.env = {global: {stack: {}}, element: span};
4004940049

40050-
span.style.color = "rgb(255, 85, 85)";
40050+
const errText = String(err);
40051+
span.style.color = "rgb(255, 85, 85)";
4005140052
span.style.background = "rgba(255, 179, 179, 0.2)";
4005240053
span.classList.add('px-2', 'py-1', 'rounded-md', 'text-xs');
40053-
span.innerText = 'Broken box';
40054+
span.innerText = errText.slice(0, Math.min(24, errText.length-1))+'...';
40055+
span.title = errText;
4005440056
console.error(err);
4005540057
};
4005640058

@@ -40338,11 +40340,12 @@ function semanticSnippet() {
4033840340
self.editor = {
4033940341
destroy: () => {},
4034040342
dispatch: () => {}
40341-
};
40343+
}; const errText = String(err);
4034240344
span.style.color = "rgb(255, 85, 85)";
4034340345
span.style.background = "rgba(255, 179, 179, 0.2)";
4034440346
span.classList.add('px-2', 'py-1', 'rounded-md', 'text-xs');
40345-
span.innerText = 'Broken box';
40347+
span.innerText = errText.slice(0, Math.min(24, errText.length-1))+'...';
40348+
span.title = errText;
4034640349
console.error(err);
4034740350
};
4034840351

modules/wljs-editor/dist/kernel.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/wljs-editor/libs/priceless-mathematica/src/boxes/boxbox.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,12 @@ function semanticSnippet() {
6666
self.editor = {
6767
destroy: () => {},
6868
dispatch: () => {}
69-
}
69+
}; const errText = String(err);
7070
span.style.color = "rgb(255, 85, 85)";
7171
span.style.background = "rgba(255, 179, 179, 0.2)";
7272
span.classList.add('px-2', 'py-1', 'rounded-md', 'text-xs');
73-
span.innerText = 'Broken box';
73+
span.innerText = errText.slice(0, Math.min(24, errText.length-1))+'...';
74+
span.title = errText;
7475
console.error(err);
7576
}
7677

modules/wljs-editor/libs/priceless-mathematica/src/boxes/viewbox.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,12 @@ import {
3737
const errBox = (span, self, err) => {
3838
self.env = {global: {stack: {}}, element: span};
3939

40-
span.style.color = "rgb(255, 85, 85)";
40+
const errText = String(err);
41+
span.style.color = "rgb(255, 85, 85)";
4142
span.style.background = "rgba(255, 179, 179, 0.2)";
4243
span.classList.add('px-2', 'py-1', 'rounded-md', 'text-xs');
43-
span.innerText = 'Broken box';
44+
span.innerText = errText.slice(0, Math.min(24, errText.length-1))+'...';
45+
span.title = errText;
4446
console.error(err);
4547
}
4648

modules/wljs-markdown-support/src/kernel.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,4 +533,8 @@ class MarkdownCell {
533533

534534
window.SupportedCells['latex'] = {
535535
view: LaTeXCell
536-
};
536+
};
537+
538+
window.SupportedCells['katex'] = {
539+
view: LaTeXCell
540+
};

0 commit comments

Comments
 (0)