Skip to content

Commit 02be80c

Browse files
authored
Delete android example (bazelbuild#3954)
These examples have always been a big pain to maintain as they require knowldge about the BuildKite runners (for NDK/SDK access) and there is no active maintainer who has a ton of context in the Bazel+Android world. While I think having the examples are nice, until the integration is made more user friendly and we have a maintainer who can vouch for it, I think they should be deleted. Should the examples be reintroduced, they must be proven to work with all active LTS versions of Bazel.
1 parent fd713d5 commit 02be80c

12 files changed

Lines changed: 0 additions & 334 deletions

File tree

.bazelci/presubmit.yml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -774,36 +774,6 @@ tasks:
774774
build_targets:
775775
- "@rust_toolchains//:all"
776776
- "//..."
777-
android_examples_ubuntu2204:
778-
name: Android Examples
779-
platform: ubuntu2204
780-
working_directory: examples/android
781-
build_flags:
782-
- "--incompatible_enable_android_toolchain_resolution"
783-
- "--android_platforms=//:arm64-v8a"
784-
build_targets:
785-
- "//:android_app"
786-
environment:
787-
# This ndk version matches with rules_android_ndk repo's CI
788-
# https://github.com/bazelbuild/rules_android_ndk/blob/877c68ef34c9f3353028bf490d269230c1990483/.bazelci/presubmit.yml#L37
789-
# The ndk is installed by this script
790-
# https://github.com/bazelbuild/continuous-integration/blob/ba56013373821feadd9f2eaa6b81eb19528795f0/macos/mac-android.sh
791-
ANDROID_NDK_HOME: /opt/android-ndk-r25b
792-
android_examples_macos:
793-
name: Android Examples
794-
platform: macos_arm64
795-
working_directory: examples/android
796-
build_flags:
797-
- "--incompatible_enable_android_toolchain_resolution"
798-
- "--android_platforms=//:arm64-v8a"
799-
build_targets:
800-
- "//:android_app"
801-
environment:
802-
# This ndk version matches with rules_android_ndk repo's CI
803-
# https://github.com/bazelbuild/rules_android_ndk/blob/877c68ef34c9f3353028bf490d269230c1990483/.bazelci/presubmit.yml#L42
804-
# The ndk is installed by this script
805-
# https://github.com/bazelbuild/continuous-integration/blob/ba56013373821feadd9f2eaa6b81eb19528795f0/macos/mac-android.sh
806-
ANDROID_NDK_HOME: /Users/buildkite/android-ndk-r25b
807777
ios_examples:
808778
name: iOS Examples
809779
platform: macos_arm64

examples/android/.bazelrc

Lines changed: 0 additions & 84 deletions
This file was deleted.

examples/android/.gitignore

Lines changed: 0 additions & 2 deletions
This file was deleted.

examples/android/AndroidMain.java

Lines changed: 0 additions & 22 deletions
This file was deleted.

examples/android/AndroidManifest.xml

Lines changed: 0 additions & 20 deletions
This file was deleted.

examples/android/BUILD.bazel

Lines changed: 0 additions & 46 deletions
This file was deleted.

examples/android/JniShim.java

Lines changed: 0 additions & 5 deletions
This file was deleted.

examples/android/MODULE.bazel

Lines changed: 0 additions & 88 deletions
This file was deleted.

examples/android/WORKSPACE.bazel

Lines changed: 0 additions & 1 deletion
This file was deleted.

examples/android/android_link_hack.c

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)