Resolved JSON Deserialization Exceptions

Author: TheCodeTraveler

AzureAdvocates.Functions/Models/GitHubContributorModel.cs

@@ -1,23 +1,26 @@
 using System.Collections.Generic;
 using System.Linq;
 using GitHubReadmeWebTrends.Common;
+using Newtonsoft.Json;
 
 namespace AzureAdvocates.Functions
 {
     class CloudAdvocateGitHubContributorModel : CloudAdvocateGitHubUserModel
     {
-        public CloudAdvocateGitHubContributorModel(in IEnumerable<RepositoryPullRequest> pullReuests, CloudAdvocateGitHubUserModel cloudAdvocateGitHubUserModel)
-            : this(pullReuests, cloudAdvocateGitHubUserModel.FullName, cloudAdvocateGitHubUserModel.GitHubUserName, cloudAdvocateGitHubUserModel.MicrosoftAlias, cloudAdvocateGitHubUserModel.MicrosoftTeam)
+        public CloudAdvocateGitHubContributorModel(IEnumerable<RepositoryPullRequest> pullRequests, CloudAdvocateGitHubUserModel cloudAdvocateGitHubUserModel)
+            : this(pullRequests, cloudAdvocateGitHubUserModel.FullName, cloudAdvocateGitHubUserModel.GitHubUserName, cloudAdvocateGitHubUserModel.MicrosoftAlias, cloudAdvocateGitHubUserModel.MicrosoftTeam)
         {
 
         }
 
-        public CloudAdvocateGitHubContributorModel(in IEnumerable<RepositoryPullRequest> pullReuests, in string fullName, in string gitHubUserName, in string microsoftAlias, in string microsoftTeam)
+        [JsonConstructor]
+        public CloudAdvocateGitHubContributorModel(IEnumerable<RepositoryPullRequest> pullRequests, string fullName, string gitHubUserName, string microsoftAlias, string microsoftTeam)
             : base(fullName, gitHubUserName, microsoftAlias, microsoftTeam)
         {
-            PullRequests = pullReuests.ToList();
+            PullRequests = pullRequests.ToList(); ;
         }
 
+        [JsonProperty("pullRequests")]
         public IReadOnlyList<RepositoryPullRequest> PullRequests { get; }
     }
 }

GitHubReadmeWebTrends.Common/Models/CloudAdvocateGitHubUserModel.cs

@@ -1,4 +1,6 @@
-namespace GitHubReadmeWebTrends.Common
+using Newtonsoft.Json;
+
+namespace GitHubReadmeWebTrends.Common
 {
     public class CloudAdvocateGitHubUserModel
     {
@@ -10,9 +12,16 @@ public CloudAdvocateGitHubUserModel(in string fullName, in string gitHubUserName
             MicrosoftTeam = microsoftTeam;
         }
 
+        [JsonProperty("fullName")]
         public string FullName { get; }
+
+        [JsonProperty("gitHubUserName")]
         public string GitHubUserName { get; }
+
+        [JsonProperty("microsoftAlias")]
         public string MicrosoftAlias { get; }
+
+        [JsonProperty("microsoftTeam")]
         public string MicrosoftTeam { get; }
     }
 }

GitHubReadmeWebTrends.Common/Models/PullRequest.cs

@@ -1,9 +1,11 @@
 using System;
+using Newtonsoft.Json;
+
 namespace GitHubReadmeWebTrends.Common
 {
     public class PullRequest
     {
-        [Newtonsoft.Json.JsonConstructor]
+        [JsonConstructor]
         public PullRequest(string id, Uri url, DateTimeOffset createdAt, bool merged, DateTimeOffset? mergedAt, string baseRefName, Author author)
             : this(id, url, createdAt, merged, mergedAt, baseRefName, author?.Login ?? string.Empty)
         {
@@ -21,25 +23,48 @@ public PullRequest(string id, Uri uri, DateTimeOffset createdAt, bool merged, Da
             Author = author;
         }
 
+        [JsonProperty("id")]
         public string Id { get; }
+
+        [JsonProperty("url")]
         public Uri Uri { get; }
+
+        [JsonProperty("createdAt")]
         public DateTimeOffset CreatedAt { get; }
+
+        [JsonProperty("merged")]
         public bool IsMerged { get; }
+
+        [JsonProperty("mergedAt")]
         public DateTimeOffset? MergedAt { get; }
+
+        [JsonProperty("baseRefName")]
         public string BaseRefName { get; }
+
+        [JsonProperty("author")]
         public string Author { get; }
     }
 
     public class RepositoryPullRequest : PullRequest
     {
         public RepositoryPullRequest(string repositoryName, string repositoryOwner, PullRequest pullRequest)
-            : base(pullRequest.Id, pullRequest.Uri, pullRequest.CreatedAt, pullRequest.IsMerged, pullRequest.MergedAt, pullRequest.BaseRefName, pullRequest.Author)
+            : this(repositoryName, repositoryOwner, pullRequest.Id, pullRequest.Uri, pullRequest.CreatedAt, pullRequest.IsMerged, pullRequest.MergedAt, pullRequest.BaseRefName, pullRequest.Author)
+        {
+
+        }
+
+        [JsonConstructor]
+        public RepositoryPullRequest(string repositoryName, string repositoryOwner, string id, Uri url, DateTimeOffset createdAt, bool merged, DateTimeOffset? mergedAt, string baseRefName, string author)
+            : base(id, url, createdAt, merged, mergedAt, baseRefName, author)
         {
             RepositoryName = repositoryName;
             RepositoryOwner = repositoryOwner;
         }
 
+        [JsonProperty("repositoryName")]
         public string RepositoryName { get; }
+
+        [JsonProperty("repositoryOwner")]
         public string RepositoryOwner { get; }
     }
 }