Skip to content
This repository was archived by the owner on Aug 10, 2022. It is now read-only.

Commit 729ce8b

Browse files
Merge pull request #23 from brminnick/Add-Time-Range
Fix Date Range Support
2 parents a6bb87f + 87b23ed commit 729ce8b

4 files changed

Lines changed: 12 additions & 11 deletions

File tree

AzureAdvocates.Functions/AzureAdvocates.Functions.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,8 @@
2020
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
2121
<CopyToPublishDirectory>Never</CopyToPublishDirectory>
2222
</None>
23+
<None Update="local.settings.json">
24+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
25+
</None>
2326
</ItemGroup>
2427
</Project>

AzureAdvocates.Functions/Functions/GetMicrosoftLearnContributors.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ public async Task<IActionResult> Run([HttpTrigger(AuthorizationLevel.Anonymous,
3737
{
3838
log.LogInformation($"{nameof(GetMicrosoftLearnContributors)} Started");
3939

40-
var timeSpan = to - from;
41-
if (timeSpan.TotalDays > 365)
42-
return new BadRequestObjectResult($"Invalid Timespan: {timeSpan.TotalDays} days. Timespan must be less than 365 days");
43-
4440
var cancellationTokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(2));
4541
var gitHubApiStatus = await _gitHubApiStatusService.GetApiRateLimits(cancellationTokenSource.Token).ConfigureAwait(false);
4642
if (gitHubApiStatus.GraphQLApi.RemainingRequestCount < 4000)
@@ -71,7 +67,7 @@ public async Task<IActionResult> Run([HttpTrigger(AuthorizationLevel.Anonymous,
7167
var cloudAdvocateContributions = new List<GitHubContributorModel>();
7268
foreach (var cloudAdvocate in cloudAdvocateList)
7369
{
74-
var cloudAdvocateContributorModel = new GitHubContributorModel(microsoftLearnPullRequests.Where(x => x.Author.Equals(cloudAdvocate.GitHubUserName, StringComparison.OrdinalIgnoreCase)), cloudAdvocate);
70+
var cloudAdvocateContributorModel = new GitHubContributorModel(microsoftLearnPullRequests.Where(x => x.Author.Equals(cloudAdvocate.GitHubUserName, StringComparison.OrdinalIgnoreCase) && x.CreatedAt.IsWithinRange(from, to)), cloudAdvocate);
7571

7672
cloudAdvocateContributions.Add(cloudAdvocateContributorModel);
7773

@@ -81,4 +77,9 @@ public async Task<IActionResult> Run([HttpTrigger(AuthorizationLevel.Anonymous,
8177
return new OkObjectResult(cloudAdvocateContributions);
8278
}
8379
}
80+
81+
static class DateTimeExtensions
82+
{
83+
public static bool IsWithinRange(this DateTimeOffset dateTimeOffset, DateTimeOffset start, DateTimeOffset end) => dateTimeOffset >= start && dateTimeOffset <= end;
84+
}
8485
}

GitHubReadmeWebTrends.Common/Services/GitHubGraphQLApiService.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ public class GitHubGraphQLApiService
1010
{
1111
readonly static IReadOnlyList<(string Owner, string Repository)> _microsoftLearnRepositories = new[]
1212
{
13-
("microsoftdocs", "learn-bizapps-pr"),
13+
("microsoftdocs", "learnshared"),
1414
("microsoftdocs", "learn-certs-pr"),
15-
("microsoftdocs", "learn-dynamics-pr"),
1615
("microsoftdocs", "learn-m365-pr"),
16+
("microsoftdocs", "learn-bizapps-pr"),
17+
("microsoftdocs", "learn-dynamics-pr"),
1718
("microsoftdocs", "learn-pr"),
18-
("microsoftdocs", "learnshared")
1919
};
2020

2121
readonly IGitHubGraphQLApiClient _gitHubGraphQLApiClient;

GitHubReadmeWebTrends.Common/Services/StartupService.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
using System;
2-
using System.Net;
32
using System.Net.Http;
43
using System.Net.Http.Headers;
54
using GitHubApiStatus.Extensions;
65
using Microsoft.Extensions.DependencyInjection;
7-
using Polly;
8-
using Polly.Extensions.Http;
96
using Refit;
107

118
namespace GitHubReadmeWebTrends.Common

0 commit comments

Comments
 (0)