Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribution issue
Automation summary
uploadFilestool description in MCP was unclear about subdirectory deployment configuration. It incorrectly suggested using "relative paths" forpublicPath/base/assetPrefix, which causes 404 errors when deploying to subdirectories (e.g.,/vite-test/). The attribution focus identified that for subdirectory deployments, the base must be an absolute path like/vite-test/(with leading slash), NOT./.mcp/src/tools/hosting.tswith three improvements:/vite-test/). Explicitly warns against using./for subdirectory deployments.localPath: Added note about uploading complete build artifact directory contents (not just index.html)cloudPath: Clarified format (relative to hosting root, no leading/) and emphasized the absolute path requirement for subdirectory deploymentsChanged files
mcp/src/tools/hosting.ts