Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Member
Author
Attribution post-PR evaluation
Cases
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribution issue
Automation summary
manageFunctionstool was missing thedeleteFunctionaction in itsMANAGE_FUNCTION_ACTIONSenum, even though the underlying CloudBase Manager SDK (@cloudbase/manager-node) already supportedcloudbase.functions.deleteFunction(name). This caused agents to receive "400 invalid parameter value" errors when attempting to delete cloud functions through the MCP tool.deleteFunctionaction tomcp/src/tools/functions.ts:"deleteFunction"to theMANAGE_FUNCTION_ACTIONSarraycase "deleteFunction":handler that requiresfunctionNameparameter andconfirm=truefor safety, then callscloudbase.functions.deleteFunction(input.functionName)deleteFunctionas an exampleconfirmparameter description to clarify which destructive actions require explicit confirmationfunctions.test.ts,build-skills-repo.test.js,build-compat-config.test.js,skill-quality-standards.test.js), and TypeScript compilation succeeds with no errors.Changed files
mcp/src/tools/functions.ts