Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Member
Author
Attribution post-PR evaluation
Cases
|
Member
Author
这个文件存在问题,原文是英文,改成了中文的
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribution issue
Automation summary
All tests pass and TypeScript compilation succeeds. Let me provide a summary of the changes. ## SUMMARY - root_cause: The MCP log query tools (
queryLogsandqueryFunctions) had unclear documentation about when to use each tool for querying cloud function logs. ThequeryLogstool'squeryStringparameter was marked as optional in the schema but required foraction=searchLogs, leading to confusing error messages. Additionally, the CLS query syntax was not documented, causing agents to fail when trying to query logs. - changes: 1. mcp/src/tools/logs.ts: - Added comprehensive tool description explaining when to usequeryLogsvsqueryFunctions- Added detailed parameter descriptions with CLS query syntax examples - Improved error message whenqueryStringis missing, including query examples and guidance to usequeryFunctionsfor function-specific logs 2. mcp/src/tools/functions.ts: - Added clear tool description explaining that this tool should be used for function logs - Added detailed action descriptions listing all available actions - Added parameter descriptions with guidance on which parameters are required for each action 3. **config/source/skills/Changed files
config/.claude/skills/cloud-functions/SKILL.mdconfig/source/skills/cloud-functions/SKILL.mdmcp/src/tools/functions.tsmcp/src/tools/logs.ts