Skip to content

Commit c27d2dc

Browse files
committed
[TASK] Drop harden-runner so the workflows can start
Both new workflows opened with step-security/harden-runner. The repository restricts Actions to an allowlist and harden-runner is not on it, so the run ended in startup_failure before any step executed. This never showed while the branch was conflicting, because a pull request that cannot be merged produces no runs. Remove the step from both workflows. Every remaining action matches the allowlist. Getting harden-runner added to it would be the better fix and is noted in the workflow header. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
1 parent 567560a commit c27d2dc

2 files changed

Lines changed: 6 additions & 25 deletions

File tree

.github/workflows/check-built-assets.yaml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,6 @@ jobs:
3939
contents: read
4040

4141
steps:
42-
- name: "Harden runner"
43-
uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4
44-
with:
45-
egress-policy: block
46-
disable-sudo: true
47-
allowed-endpoints: >
48-
api.github.com:443
49-
github.com:443
50-
objects.githubusercontent.com:443
51-
release-assets.githubusercontent.com:443
52-
registry.npmjs.org:443
53-
5442
- name: "Checkout"
5543
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
5644
with:

.github/workflows/dependabot-rebuild-assets.yaml

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,15 @@
1616
# the PR opened with
1717
# - lockfile-only diff guard: refuse to build if the PR changed anything
1818
# other than package.json / package-lock.json
19-
# - npm ci --ignore-scripts; harden-runner egress in block mode
19+
# - npm ci --ignore-scripts
2020
# - the App token is minted AFTER the build, so the untrusted build cannot
2121
# read it; persist-credentials: false keeps it off disk
2222
#
23+
# Egress filtering via step-security/harden-runner is not available here: the
24+
# repository restricts workflows to an allowlist of actions and harden-runner
25+
# is not on it. Adding it there would let both workflows in this branch pin
26+
# their network access.
27+
#
2328
# The rebuilt files are committed via the GitHub API (createCommitOnBranch)
2429
# with a short-lived GitHub App token, never `git push`. API commits are
2530
# signed server-side by GitHub (Verified), and an App-token commit re-triggers
@@ -46,18 +51,6 @@ jobs:
4651
contents: read
4752

4853
steps:
49-
- name: "Harden runner"
50-
uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4
51-
with:
52-
egress-policy: block
53-
disable-sudo: true
54-
allowed-endpoints: >
55-
api.github.com:443
56-
github.com:443
57-
objects.githubusercontent.com:443
58-
release-assets.githubusercontent.com:443
59-
registry.npmjs.org:443
60-
6154
- name: "Checkout Dependabot branch"
6255
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
6356
with:

0 commit comments

Comments
 (0)