Commit 9314045
committed
[BUGFIX] Draw the unresolved-reference marker, and say it plainly
Amends the previous commit after review.
The screen-reader-only sentence is withdrawn. It was a real text node, and
confval-menu renders its field content and then runs striptags over the result,
so with "max=" set the sentence became visible table text, became the cell's
tooltip, and added 38 characters to the length that decides whether the value is
truncated at all. Keeping it would mean coupling two templates through a literal
string or teaching an unrelated feature a regex filter; neither belongs in this
change. The measured benefit was also smaller than claimed: Chrome already
exposes the title attribute as the marker's accessible description.
What stays is what was measured. Before, computed textDecorationLine on
span.invalid-link was "none": "dotted" sets only the style, and the shorthand
resolves the omitted line to its initial value. The marker was distinguished
from surrounding text by a #f2f2f2 background and nothing else, which is
WCAG 1.4.1 Use of Color. With a line value the dotted underline is drawn, in the
text colour, so the cue is achromatic.
The wording loses "anymore". It asserts that the reference once worked; the
fixture's two references never resolved, and the build logs "Inventory link not
found" for both. Same element, same change, one word.
Also drops a dead branch: the span sits in the else of "if node.url" and opened
with "if node.url" again, so its first arm could never be taken.
Assisted-by: claude-code:claude-opus-5
Agent-Session: https://claude.ai/code/session_012Zm6UrYoeXRnucAdTdLRuN
Agent-Host: 0493f0
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>1 parent 63caebb commit 9314045
2 files changed
Lines changed: 3 additions & 4 deletions
File tree
- packages/typo3-docs-theme/resources/template/inline
- tests/Integration/tests/interlink/interlink-warn/expected
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
0 commit comments