Skip to content

Commit b46cca0

Browse files
committed
fix(ci): draft release flow + Windows zip + always publish
- GoReleaser creates draft release (SAP-samples org locks published ones) - Signing workflow publishes release as final step (always runs) - Use 7z instead of zip on Windows runners (zip not in PATH) - Force Scoop/Homebrew manifest commits even for draft releases - Remove success-only guard on signing (ensures publish step always runs)
1 parent 4c27dcb commit b46cca0

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

.github/workflows/release-tray.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
run: |
7878
ASSET="sap-devs-tray_${VERSION}_${{ matrix.goos }}_${{ matrix.goarch }}"
7979
if [ "${{ matrix.goos }}" = "windows" ]; then
80-
zip "${ASSET}.zip" -j cmd/sap-devs-tray/sap-devs-tray.exe
80+
7z a "${ASSET}.zip" ./cmd/sap-devs-tray/sap-devs-tray.exe
8181
else
8282
tar czf "${ASSET}.tar.gz" -C cmd/sap-devs-tray sap-devs-tray
8383
fi

.github/workflows/sign-windows.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ permissions:
1111
jobs:
1212
sign:
1313
runs-on: ubuntu-latest
14-
if: github.event.workflow_run.conclusion == 'success'
1514
outputs:
1615
signed: ${{ steps.result.outputs.signed }}
1716
steps:
@@ -177,3 +176,8 @@ jobs:
177176
echo "::warning::Signing incomplete — release ships with unsigned binaries"
178177
echo "::warning::Download: ${{ steps.download.outcome }}, Extract: ${{ steps.extract.outcome }}, Sign: ${{ steps.sign.outcome }}, Repackage: ${{ steps.repackage.outcome }}, Upload: ${{ steps.upload.outcome }}, Scoop: ${{ steps.scoop-manifest.outcome }}"
179178
fi
179+
180+
- name: Publish release
181+
env:
182+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
183+
run: gh release edit "$TAG" --draft=false

.goreleaser.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ release:
66
github:
77
owner: SAP-samples
88
name: sap-devs-cli
9+
draft: true
910

1011
builds:
1112
- main: .
@@ -51,6 +52,7 @@ changelog:
5152

5253
scoops:
5354
- ids: [archives]
55+
skip_upload: "false"
5456
repository:
5557
owner: SAP-samples
5658
name: sap-devs-cli
@@ -63,6 +65,7 @@ scoops:
6365

6466
homebrew_casks:
6567
- ids: [archives]
68+
skip_upload: "false"
6669
repository:
6770
owner: SAP-samples
6871
name: sap-devs-cli

0 commit comments

Comments
 (0)