-
Notifications
You must be signed in to change notification settings - Fork 175
[Feature] Recursively search packs directory for valid packs #352
Copy link
Copy link
Open
Labels
Note: Good First IssueGood for anyone looking to learn the internals of TerraGood for anyone looking to learn the internals of TerraStatus: PendingIssue/PR is currently awaiting approval by a moderator.Issue/PR is currently awaiting approval by a moderator.Type: EnhancementA request for a new feature or enhancement to be added.A request for a new feature or enhancement to be added.
Description
Activity
Metadata
Metadata
Assignees
Labels
Note: Good First IssueGood for anyone looking to learn the internals of TerraGood for anyone looking to learn the internals of TerraStatus: PendingIssue/PR is currently awaiting approval by a moderator.Issue/PR is currently awaiting approval by a moderator.Type: EnhancementA request for a new feature or enhancement to be added.A request for a new feature or enhancement to be added.
Pre-Request Checklist
ones, and found none.
should be implemented by a pack or addon.
Feature Description
Allow packs to be placed in arbitrary directory structures within the
packsdirectory, where the requirement for a folder to be loaded as a pack is that it immediately contains apack.yml.An example of a valid setup:
pack-1,pack-2.zip,pack-a, andpack-bwould be loaded as config packs.What Problem Does This Solve?
I feel like pack installation is needlessly complicated because of the strict requirement of where the manifest should be - this would allow installation of packs to be simpler for end users. In many cases you could just download the source of a pack directly from github and drop it in the packs directory without worrying about the directories being nested.
A Solution You'd Like
Run a BFS on folders and zips contained in the
packsdirectory, and attempt to load any directories containing apack.ymlas a config pack. BFS would be terminated at directories identified as packs so pack subdirs aren't searched.