Refactor handling of lists (#356)

Author: aalmada

NetFabric.Hyperlinq.Benchmarks/Benchmarks/SelectBenchmarks.cs

@@ -269,21 +269,7 @@ public int Hyperlinq_Collection_Value()
 
         [BenchmarkCategory("List_Value")]
         [Benchmark]
-        public int Hyperlinq_List_Value_For()
-        {
-            var source = listValue.AsValueEnumerable().Select(item => item);
-            var sum = 0;
-            for (var index = 0; index < source.Count; index++)
-            {
-                var item = source[index];
-                sum += item;
-            }
-            return sum;
-        }
-
-        [BenchmarkCategory("List_Value")]
-        [Benchmark]
-        public int Hyperlinq_List_Value_Foreach()
+        public int Hyperlinq_List_Value()
         {
             var sum = 0;
             foreach (var item in listValue.AsValueEnumerable().Select(item => item))
@@ -321,21 +307,10 @@ public int Hyperlinq_Collection_Reference()
             return sum;
         }
 
-        [BenchmarkCategory("List_Reference")]
-        [Benchmark]
-        public int Hyperlinq_List_Reference_For()
-        {
-            var source = listReference.AsValueEnumerable().Select(item => item);
-            var sum = 0;
-            for (var index = 0; index < source.Count; index++)
-                sum += source[index];
-            return sum;
-        }
-
 #pragma warning disable HLQ010 // Consider using a 'for' loop instead.
         [BenchmarkCategory("List_Reference")]
         [Benchmark]
-        public int Hyperlinq_List_Reference_Foreach()
+        public int Hyperlinq_List_Reference()
         {
             var sum = 0;
             foreach (var item in listReference.AsValueEnumerable().Select(item => item))

NetFabric.Hyperlinq.UnitTests/Aggregation/Count/Count.ReadOnlyList.Tests.cs

@@ -22,7 +22,7 @@ public void AsValueEnumerable_With_ValidData_Must_Succeed(int[] source)
 
             // Assert
             _ = result.Must()
-                .BeOfType<ValueReadOnlyListExtensions.ValueEnumerable<Wrap.ValueReadOnlyListWrapper<int>, int>>()
+                .BeOfType<ReadOnlyListExtensions.ValueEnumerable<Wrap.ValueReadOnlyListWrapper<int>, int>>()
                 .BeEnumerableOf<int>()
                 .BeEqualTo(wrapped);
         }