Merge pull request #467 from NeoCoderMatrix86/465-export-cuesheet-throws-exception-when-used-with-invalid-tracks

Export cuesheet throws exception when used with invalid tracks

Author: NeoCoderMatrix86

AudioCuesheetEditor.Tests/Services/IO/CuesheetExportServiceTests.cs

@@ -62,7 +62,12 @@ public void CanGenerateExportfiles_ValidExtension_ReturnsEmpty()
                 Title = "Test Title",
                 Audiofile = new Audiofile("Audio.mp3")
             };
-            cuesheet.AddTrack(new Track());
+            cuesheet.AddTrack(new Track()
+            {
+                Position = 1,
+                Begin = TimeSpan.Zero,
+                End = new TimeSpan(0, 3, 43)
+            });
             sessionStateContainerMock.SetupProperty(x => x.Cuesheet, cuesheet);
 
             // Act
@@ -221,5 +226,35 @@ TRACK 02 AUDIO
 		INDEX 01 01:54:00
 ", contentString);
         }
+
+        [TestMethod]
+        public void GenerateExportfiles_WithInvalidTracks_ReturnsEmpty()
+        {
+            // Arrange
+            var cuesheet = new Cuesheet()
+            {
+                Artist = "Test Artist",
+                Title = "Test Title",
+                Audiofile = new Audiofile("Audio.mp3")
+            };
+            var track1 = new Track()
+            {
+                Position = 1,
+                Begin = TimeSpan.Zero,
+            };
+            var track2 = new Track()
+            {
+                Position = 2,
+            };
+            cuesheet.AddTrack(track1);
+            cuesheet.AddTrack(track2);
+            sessionStateContainerMock.SetupProperty(x => x.Cuesheet, cuesheet);
+
+            // Act
+            var result = cuesheetExportService.GenerateExportfiles("test.cue");
+
+            // Assert
+            Assert.AreEqual(0, result.Count);
+        }
     }
 }

AudioCuesheetEditor.Tests/Services/IO/ExportfileGeneratorTests.cs

@@ -220,5 +220,44 @@ public void GenerateExportFile_ShouldHandleEmptyProfile()
             Assert.AreEqual(new TimeSpan(0, 8, 32), result.First().End);
             Assert.IsNotNull(result.First().Content);
         }
+
+        [TestMethod]
+        public void GenerateExportFile_ReturnsEmpty_WithInvalidTracks()
+        {
+            // Arrange
+            var exportProfile = new Exportprofile
+            {
+                Name = "TestProfile",
+                SchemeHead = "%Cuesheet.Artist% - %Cuesheet.Title%",
+                SchemeTracks = "%Track.Position% %Track.Artist% - %Track.Title%",
+                Filename = "TestExport.txt"
+            };
+            var cuesheet = new Cuesheet()
+            {
+                Artist = "Test artist cuesheet",
+                Title = "Test title cuesheet",
+                Audiofile = new Audiofile("Test audiofile.mp3")
+            };
+            cuesheet.AddTrack(new Track()
+            {
+                Artist = "Test artist 1",
+                Title = "Test title 1",
+                Begin = TimeSpan.Zero,
+                Position = 1
+            });
+            cuesheet.AddTrack(new Track()
+            {
+                Artist = "Test artist 2",
+                Title = "Test title 2",
+                Position = 2
+            });
+            mockSessionStateContainer.SetupProperty(x => x.Cuesheet, cuesheet);
+
+            // Act
+            var result = exportfileGenerator.GenerateExportfiles(exportProfile);
+
+            // Assert
+            Assert.AreEqual(0, result.Count);
+        }
     }
 }

AudioCuesheetEditor/AudioCuesheetEditor.csproj

@@ -7,7 +7,7 @@
 	<ImplicitUsings>enable</ImplicitUsings>
 	<PackageProjectUrl>https://github.com/NeoCoderMatrix86/AudioCuesheetEditor</PackageProjectUrl>
 	<RazorLangVersion>3.0</RazorLangVersion>
-	<Version>9.1.0</Version>
+	<Version>9.2.0</Version>
 	<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
 	<PublishTrimmed>true</PublishTrimmed>
 	<RunAOTCompilation>true</RunAOTCompilation>

AudioCuesheetEditor/Services/IO/CuesheetExportService.cs

@@ -36,6 +36,7 @@ public IEnumerable<ValidationMessage> CanGenerateExportfiles(string? filename)
                 validationMessages.Add(new ValidationMessage("File extension is not '{0}'", FileExtensions.Cuesheet));
             }
             validationMessages.AddRange(_sessionStateContainer.Cuesheet.Validate().ValidationMessages);
+            validationMessages.AddRange(_sessionStateContainer.Cuesheet.Tracks.Select(x => x.Validate()).SelectMany(x => x.ValidationMessages));
             return validationMessages;
         }
 

AudioCuesheetEditor/Services/IO/ExportfileGenerator.cs

@@ -38,6 +38,7 @@ public IEnumerable<ValidationMessage> CanGenerateExportfiles(Exportprofile? expo
                 validationMessages.Add(new ValidationMessage("No exportprofile selected!"));
             }
             validationMessages.AddRange(_sessionStateContainer.Cuesheet.Validate().ValidationMessages);
+            validationMessages.AddRange(_sessionStateContainer.Cuesheet.Tracks.Select(x => x.Validate()).SelectMany(x => x.ValidationMessages));
             return validationMessages;
         }