Skip to content

Commit 8389e82

Browse files
NeoCoderMatrix86NeoCoderMatrix86
authored
Merge pull request #543 from NeoCoderMatrix86/411-make-export-profiles-also-visible-without-download
Make export profiles also visible without download
2 parents f83f0e9 + 1e3e089 commit 8389e82

35 files changed

Lines changed: 529 additions & 204 deletions

‎AudioCuesheetEditor.End2EndTests/Models/DetailView.cs‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,11 @@
1717

1818
namespace AudioCuesheetEditor.End2EndTests.Models
1919
{
20-
internal class DetailView(IPage page, bool mobile)
20+
internal class DetailView(IPage page)
2121
{
2222
internal const string BaseUrl = "http://localhost:5132/";
2323

2424
private readonly IPage _page = page;
25-
private readonly bool _isMobile = mobile;
2625

2726
internal ILocator AudiofileInput => _page.GetByRole(AriaRole.Group).Filter(new() { HasText = "AudiofileAudiofile" }).Locator("input[type=\"file\"]");
2827

@@ -115,8 +114,7 @@ internal async Task RenameAudiofileAsync(string filename)
115114

116115
internal async Task OpenRenameAudiofileDialogAsync()
117116
{
118-
int buttonIndex = _isMobile ? 2 : 3;
119-
await _page.GetByRole(AriaRole.Group).Filter(new() { HasText = "AudiofileAudiofile" }).GetByRole(AriaRole.Button).Nth(buttonIndex).ClickAsync();
117+
await _page.GetByRole(AriaRole.Group).Filter(new() { HasText = "AudiofileAudiofile" }).GetByLabel("More").ClickAsync();
120118
await _page.GetByText("Rename file").ClickAsync();
121119
}
122120
}

‎AudioCuesheetEditor.End2EndTests/Models/RecordView.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ internal async Task AddRecordingTrackAsync(string artist, string title)
5050
await _page.GetByRole(AriaRole.Textbox, new() { Name = "Title", Exact = true }).FillAsync(title);
5151
await _page.GetByRole(AriaRole.Textbox, new() { Name = "Title", Exact = true }).PressAsync("Tab");
5252
await _page.GetByRole(AriaRole.Button, new() { Name = "Add track" }).ClickAsync();
53-
await _page.Locator(".mud-overlay").ClickAsync();
5453
}
5554
}
5655
}

‎AudioCuesheetEditor.End2EndTests/Tests/Desktop/BasicTest.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class BasicTest : PlaywrightTestBase
2424
[TestMethod]
2525
public async Task Application_HasTitle_WhenBrowsingIndex()
2626
{
27-
var detailView = new DetailView(TestPage, DeviceName != null);
27+
var detailView = new DetailView(TestPage);
2828
await detailView.GotoAsync();
2929
var appBar = new AppBar(TestPage);
3030
await Expect(appBar.HomeButton).ToBeVisibleAsync();
@@ -43,7 +43,7 @@ public async Task AboutHeader_HasTitle_WhenBrowsingAbout()
4343
[TestMethod]
4444
public async Task Audiofile_ShouldBeRenamed_WhenEditingFilename()
4545
{
46-
var detailView = new DetailView(TestPage, DeviceName != null);
46+
var detailView = new DetailView(TestPage);
4747
await detailView.GotoAsync();
4848
await detailView.AudiofileInput.SetInputFilesAsync("Kalimba.mp3");
4949
await detailView.RenameAudiofileAsync("Kalimba test 123.mp3");
@@ -54,7 +54,7 @@ public async Task Audiofile_ShouldBeRenamed_WhenEditingFilename()
5454
public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
5555
{
5656
var bar = new AppBar(TestPage);
57-
var detailView = new DetailView(TestPage, DeviceName != null);
57+
var detailView = new DetailView(TestPage);
5858
await detailView.GotoAsync();
5959
await bar.OpenSettingsAsync();
6060
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Settings" })).ToBeVisibleAsync();
@@ -65,7 +65,7 @@ public async Task ChangeLanguage_ShouldSwitchLanguage_WhenGermanIsSelected()
6565
{
6666
var bar = new AppBar(TestPage);
6767
var exportDialog = new ExportDialog(TestPage);
68-
var detailView = new DetailView(TestPage, DeviceName != null);
68+
var detailView = new DetailView(TestPage);
6969
await detailView.GotoAsync();
7070
await bar.ChangeLanguageAsync("German (Germany)");
7171
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Abschnitte" })).ToBeVisibleAsync();
@@ -86,7 +86,7 @@ public async Task ChangeLanguage_ShouldSwitchLanguage_WhenGermanIsSelected()
8686
public async Task TrackTableControls_ShouldBeEnabled_WhenSelectingFirstTrackAsync()
8787
{
8888
var bar = new AppBar(TestPage);
89-
var detailView = new DetailView(TestPage, DeviceName != null);
89+
var detailView = new DetailView(TestPage);
9090
await detailView.GotoAsync();
9191
await detailView.AddTrackAsync();
9292
await detailView.AddTrackAsync();
@@ -108,7 +108,7 @@ await Expect(TestPage.GetByLabel("Track table controls")).ToMatchAriaSnapshotAsy
108108
public async Task KeyboardCommands_ShouldControlDialogs_WhenUsingEnterOrEscapeAsync()
109109
{
110110
var bar = new AppBar(TestPage);
111-
var detailView = new DetailView(TestPage, DeviceName != null);
111+
var detailView = new DetailView(TestPage);
112112
await detailView.GotoAsync();
113113
await TestPage.GetByRole(AriaRole.Dialog).WaitForAsync(new() { State = WaitForSelectorState.Detached });
114114
await bar.OpenExportDialogAsync("Cuesheet");

‎AudioCuesheetEditor.End2EndTests/Tests/Desktop/ExportTest.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class ExportTest : PlaywrightTestBase
2525
public async Task DownloadCuesheet_GeneratesCuesheetFile_WhenCuesheetIsValid()
2626
{
2727
var bar = new AppBar(TestPage);
28-
var detailView = new DetailView(TestPage, DeviceName != null);
28+
var detailView = new DetailView(TestPage);
2929
await detailView.GotoAsync();
3030
await detailView.AddTrackAsync();
3131
await detailView.CuesheetArtistInput.FillAsync("Cuesheet Artist 1");
@@ -54,7 +54,7 @@ TRACK 01 AUDIO
5454
public async Task DownloadProject_GeneratesProjectFile_WhenCuesheetIsValidAsync()
5555
{
5656
var bar = new AppBar(TestPage);
57-
var detailView = new DetailView(TestPage, DeviceName != null);
57+
var detailView = new DetailView(TestPage);
5858
await detailView.GotoAsync();
5959
await detailView.AddTrackAsync();
6060
await detailView.CuesheetArtistInput.FillAsync("Cuesheet Artist 1");
@@ -75,7 +75,7 @@ public async Task DownloadProject_GeneratesProjectFile_WhenCuesheetIsValidAsync(
7575
public async Task DownloadText_GeneratesTextFile_WhenCuesheetIsValidAsync()
7676
{
7777
var bar = new AppBar(TestPage);
78-
var detailView = new DetailView(TestPage, DeviceName != null);
78+
var detailView = new DetailView(TestPage);
7979
await detailView.GotoAsync();
8080
await detailView.AddTrackAsync();
8181
await detailView.CuesheetArtistInput.FillAsync("Cuesheet Artist 1");
@@ -85,7 +85,7 @@ public async Task DownloadText_GeneratesTextFile_WhenCuesheetIsValidAsync()
8585
await bar.OpenExportDialogAsync("Textfile");
8686
await TestPage.GetByRole(AriaRole.Button, new() { Name = "Next", Exact = true }).ClickAsync();
8787
var downloadTask = TestPage.WaitForDownloadAsync();
88-
await TestPage.GetByRole(AriaRole.Button, new() { Name = "Download-YouTube.txt" }).ClickAsync();
88+
await TestPage.GetByRole(AriaRole.Button, new() { Name = "Download" }).ClickAsync();
8989
var download = await downloadTask;
9090
using var stream = await download.CreateReadStreamAsync();
9191
using var reader = new StreamReader(stream);

‎AudioCuesheetEditor.End2EndTests/Tests/Desktop/ImportTest.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class ImportTest : PlaywrightTestBase
2525
public async Task Import_ShouldImportTracks_WhenUsingSampleInputfile()
2626
{
2727
var importView = new ImportView(TestPage, DeviceName != null);
28-
var detailView = new DetailView(TestPage, DeviceName != null);
28+
var detailView = new DetailView(TestPage);
2929
await importView.GotoAsync();
3030
await importView.ImportFileAsync("Sample_Inputfile.txt");
3131
await importView.Analyze();
@@ -1690,7 +1690,7 @@ await Expect(TestPage.GetByRole(AriaRole.Table)).ToMatchAriaSnapshotAsync(@"- ta
16901690
[TestMethod]
16911691
public async Task Open_ShouldImportProject_WhenUsingProjectfile()
16921692
{
1693-
var detailView = new DetailView(TestPage, DeviceName != null);
1693+
var detailView = new DetailView(TestPage);
16941694
var appBar = new AppBar(TestPage);
16951695
await detailView.GotoAsync();
16961696
await appBar.OpenFileAsync("Sample_Project.ace");
@@ -1919,7 +1919,7 @@ await Expect(TestPage.GetByRole(AriaRole.Table)).ToMatchAriaSnapshotAsync(@"- ta
19191919
[TestMethod]
19201920
public async Task Open_ShouldImportCuesheet_WhenUsingCuesheetfile()
19211921
{
1922-
var detailView = new DetailView(TestPage, DeviceName != null);
1922+
var detailView = new DetailView(TestPage);
19231923
var appBar = new AppBar(TestPage);
19241924
await detailView.GotoAsync();
19251925
await appBar.OpenFileAsync("Sample_Cuesheet.cue");

‎AudioCuesheetEditor.End2EndTests/Tests/Desktop/RecordTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public async Task Record_ShouldRecordTracks_WhenTracksAdded()
2626
{
2727
var recordView = new RecordView(TestPage);
2828
var viewModes = new ViewModes(TestPage, DeviceName != null);
29-
var detailView = new DetailView(TestPage, DeviceName != null);
29+
var detailView = new DetailView(TestPage);
3030
await recordView.GotoAsync();
3131
await recordView.StartRecordingAsync();
3232
await recordView.AddRecordingTrackAsync("Test Track 1 Artist", "Test Track 1 Title");

‎AudioCuesheetEditor.End2EndTests/Tests/Desktop/TracingTest.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class TracingTest : PlaywrightTestBase
2525
public async Task UndoRedo_ShouldRestoreTrackState_WhenUndoAndRedoAreUsed()
2626
{
2727
var bar = new AppBar(TestPage);
28-
var detailView = new DetailView(TestPage, DeviceName != null);
28+
var detailView = new DetailView(TestPage);
2929
await detailView.GotoAsync();
3030
await detailView.AddTrackAsync();
3131
await detailView.EditTrackAsync("Test Artist 1");
@@ -247,7 +247,7 @@ await Expect(TestPage.GetByRole(AriaRole.Table)).ToMatchAriaSnapshotAsync(@"- ta
247247
public async Task UndoRedo_ShouldRestoreTrackState_WhenModalEdit()
248248
{
249249
var bar = new AppBar(TestPage);
250-
var detailView = new DetailView(TestPage, DeviceName != null);
250+
var detailView = new DetailView(TestPage);
251251
await detailView.GotoAsync();
252252
await detailView.AddTrackAsync();
253253
await detailView.SelectTracksAsync([1]);

‎AudioCuesheetEditor.End2EndTests/Tests/Smartphone/BasicTestSmartphone.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class BasicTestSmartphone : PlaywrightTestBase
2626
[TestMethod]
2727
public async Task Application_HasTitle_WhenBrowsingIndex()
2828
{
29-
var detailView = new DetailView(TestPage, DeviceName != null);
29+
var detailView = new DetailView(TestPage);
3030
await detailView.GotoAsync();
3131
var appBar = new AppBar(TestPage);
3232
await Expect(appBar.HomeButton).ToBeVisibleAsync();
@@ -45,7 +45,7 @@ public async Task AboutHeader_HasTitle_WhenBrowsingAbout()
4545
[TestMethod]
4646
public async Task Audiofile_ShouldBeRenamed_WhenEditingFilename()
4747
{
48-
var detailView = new DetailView(TestPage, DeviceName != null);
48+
var detailView = new DetailView(TestPage);
4949
await detailView.GotoAsync();
5050
await detailView.AudiofileInput.SetInputFilesAsync("Kalimba.mp3");
5151
await detailView.RenameAudiofileAsync("Kalimba test 123.mp3");
@@ -56,7 +56,7 @@ public async Task Audiofile_ShouldBeRenamed_WhenEditingFilename()
5656
public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
5757
{
5858
var bar = new AppBar(TestPage);
59-
var detailView = new DetailView(TestPage, DeviceName != null);
59+
var detailView = new DetailView(TestPage);
6060
await detailView.GotoAsync();
6161
await bar.OpenSettingsAsync();
6262
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Settings" })).ToBeVisibleAsync();
@@ -67,7 +67,7 @@ public async Task ChangeLanguage_ShouldSwitchLanguage_WhenGermanIsSelected()
6767
{
6868
var bar = new AppBar(TestPage);
6969
var exportDialog = new ExportDialog(TestPage);
70-
var detailView = new DetailView(TestPage, DeviceName != null);
70+
var detailView = new DetailView(TestPage);
7171
await detailView.GotoAsync();
7272
await bar.ChangeLanguageAsync("German (Germany)");
7373
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Abschnitte" })).ToBeVisibleAsync();
@@ -88,7 +88,7 @@ public async Task ChangeLanguage_ShouldSwitchLanguage_WhenGermanIsSelected()
8888
public async Task TrackTableControls_ShouldBeEnabled_WhenSelectingFirstTrackAsync()
8989
{
9090
var bar = new AppBar(TestPage);
91-
var detailView = new DetailView(TestPage, DeviceName != null);
91+
var detailView = new DetailView(TestPage);
9292
await detailView.GotoAsync();
9393
await detailView.AddTrackAsync();
9494
await detailView.AddTrackAsync();
@@ -107,7 +107,7 @@ await Expect(TestPage.GetByLabel("Track table controls")).ToMatchAriaSnapshotAsy
107107
public async Task KeyboardCommands_ShouldControlDialogs_WhenUsingEnterOrEscapeAsync()
108108
{
109109
var bar = new AppBar(TestPage);
110-
var detailView = new DetailView(TestPage, DeviceName != null);
110+
var detailView = new DetailView(TestPage);
111111
await detailView.GotoAsync();
112112
await TestPage.GetByRole(AriaRole.Dialog).WaitForAsync(new() { State = WaitForSelectorState.Detached });
113113
await bar.OpenExportDialogAsync("Cuesheet");

‎AudioCuesheetEditor.End2EndTests/Tests/Smartphone/ExportTestSmartphone.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class ExportTestSmartphone : PlaywrightTestBase
2525
public async Task DownloadCuesheet_GeneratesCuesheetFile_WhenCuesheetIsValid()
2626
{
2727
var bar = new AppBar(TestPage);
28-
var detailView = new DetailView(TestPage, DeviceName != null);
28+
var detailView = new DetailView(TestPage);
2929
await detailView.GotoAsync();
3030
await detailView.AddTrackAsync();
3131
await detailView.CuesheetArtistInput.FillAsync("Cuesheet Artist 1");
@@ -54,7 +54,7 @@ TRACK 01 AUDIO
5454
public async Task DownloadProject_GeneratesProjectFile_WhenCuesheetIsValidAsync()
5555
{
5656
var bar = new AppBar(TestPage);
57-
var detailView = new DetailView(TestPage, DeviceName != null);
57+
var detailView = new DetailView(TestPage);
5858
await detailView.GotoAsync();
5959
await detailView.AddTrackAsync();
6060
await detailView.CuesheetArtistInput.FillAsync("Cuesheet Artist 1");
@@ -75,7 +75,7 @@ public async Task DownloadProject_GeneratesProjectFile_WhenCuesheetIsValidAsync(
7575
public async Task DownloadText_GeneratesTextFile_WhenCuesheetIsValidAsync()
7676
{
7777
var bar = new AppBar(TestPage);
78-
var detailView = new DetailView(TestPage, DeviceName != null);
78+
var detailView = new DetailView(TestPage);
7979
await detailView.GotoAsync();
8080
await detailView.AddTrackAsync();
8181
await detailView.CuesheetArtistInput.FillAsync("Cuesheet Artist 1");
@@ -85,7 +85,7 @@ public async Task DownloadText_GeneratesTextFile_WhenCuesheetIsValidAsync()
8585
await bar.OpenExportDialogAsync("Textfile");
8686
await TestPage.GetByRole(AriaRole.Button, new() { Name = "Next", Exact = true }).ClickAsync();
8787
var downloadTask = TestPage.WaitForDownloadAsync();
88-
await TestPage.GetByRole(AriaRole.Button, new() { Name = "Download-YouTube.txt" }).ClickAsync();
88+
await TestPage.GetByRole(AriaRole.Button, new() { Name = "Download" }).ClickAsync();
8989
var download = await downloadTask;
9090
using var stream = await download.CreateReadStreamAsync();
9191
using var reader = new StreamReader(stream);

‎AudioCuesheetEditor.End2EndTests/Tests/Smartphone/ImportTestSmartphone.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class ImportTestSmartphone : PlaywrightTestBase
2727
public async Task Import_ShouldImportTracks_WhenUsingSampleInputfile()
2828
{
2929
var importView = new ImportView(TestPage, DeviceName != null);
30-
var detailView = new DetailView(TestPage, DeviceName != null);
30+
var detailView = new DetailView(TestPage);
3131
await importView.GotoAsync();
3232
await importView.ImportFileAsync("Sample_Inputfile.txt");
3333
await importView.Analyze();
@@ -3067,7 +3067,7 @@ await Expect(TestPage.GetByRole(AriaRole.Table)).ToMatchAriaSnapshotAsync(@"- ta
30673067
[TestMethod]
30683068
public async Task Open_ShouldImportProject_WhenUsingProjectfile()
30693069
{
3070-
var detailView = new DetailView(TestPage, DeviceName != null);
3070+
var detailView = new DetailView(TestPage);
30713071
var appBar = new AppBar(TestPage);
30723072
await detailView.GotoAsync();
30733073
await appBar.OpenFileAsync("Sample_Project.ace");
@@ -3320,7 +3320,7 @@ await Expect(TestPage.GetByRole(AriaRole.Table)).ToMatchAriaSnapshotAsync(@"- ta
33203320
[TestMethod]
33213321
public async Task Open_ShouldImportCuesheet_WhenUsingCuesheetfile()
33223322
{
3323-
var detailView = new DetailView(TestPage, DeviceName != null);
3323+
var detailView = new DetailView(TestPage);
33243324
var appBar = new AppBar(TestPage);
33253325
await detailView.GotoAsync();
33263326
await appBar.OpenFileAsync("Sample_Cuesheet.cue");

0 commit comments

Comments
 (0)