Skip to content

Commit 3719b83

Browse files
NeoCoderMatrix86NeoCoderMatrix86
committed
removed appbar GotoAsync()
1 parent 619c9e7 commit 3719b83

6 files changed

Lines changed: 14 additions & 20 deletions

File tree

‎AudioCuesheetEditor.End2EndTests/Models/AppBar.cs‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ namespace AudioCuesheetEditor.End2EndTests.Models
55
{
66
internal class AppBar
77
{
8-
internal const string BaseUrl = "http://localhost:5132/";
9-
108
private readonly IPage _page;
119
private readonly ILocator _menuButton;
1210

@@ -25,13 +23,6 @@ internal AppBar(IPage page)
2523
.Nth(3);
2624
}
2725

28-
internal async Task GotoAsync()
29-
{
30-
await _page.GotoAsync(BaseUrl);
31-
await _page.WaitForURLAsync(BaseUrl);
32-
await _page.WaitForLoadStateAsync(LoadState.NetworkIdle);
33-
}
34-
3526
internal async Task OpenSettingsAsync()
3627
{
3728
await _menuButton.ClickAsync();

‎AudioCuesheetEditor.End2EndTests/Models/DetailView.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ internal class DetailView(IPage page, bool mobile)
1515

1616
internal ILocator CuesheetTitleInput => _page.GetByRole(AriaRole.Textbox, new() { Name = "Cuesheet title" });
1717

18-
//TODO: Remove this method
1918
internal async Task GotoAsync()
2019
{
2120
await _page.GotoAsync(BaseUrl);

‎AudioCuesheetEditor.End2EndTests/Tests/Desktop/BasicTest.cs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ public async Task Audiofile_ShouldBeRenamed_WhenEditingFilename()
3939
public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
4040
{
4141
var bar = new AppBar(TestPage);
42-
await bar.GotoAsync();
42+
var detailView = new DetailView(TestPage, DeviceName != null);
43+
await detailView.GotoAsync();
4344
await bar.OpenSettingsAsync();
4445
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Settings" })).ToBeVisibleAsync();
4546
}
@@ -48,7 +49,8 @@ public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
4849
public async Task ChangeLanguage_ShouldShowGermanHeadings_WhenGermanIsSelected()
4950
{
5051
var bar = new AppBar(TestPage);
51-
await bar.GotoAsync();
52+
var detailView = new DetailView(TestPage, DeviceName != null);
53+
await detailView.GotoAsync();
5254
await bar.ChangeLanguageAsync("German (Germany)");
5355
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Abschnitte" })).ToBeVisibleAsync();
5456
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Allgemeine Informationen" })).ToBeVisibleAsync();

‎AudioCuesheetEditor.End2EndTests/Tests/Desktop/TracingTest.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ public class TracingTest : PlaywrightTestBase
1010
public async Task UndoRedo_ShouldRestoreTrackState_WhenUndoAndRedoAreUsed()
1111
{
1212
var bar = new AppBar(TestPage);
13-
await bar.GotoAsync();
1413
var detailView = new DetailView(TestPage, DeviceName != null);
14+
await detailView.GotoAsync();
1515
await detailView.AddTrackAsync();
1616
await detailView.EditTrackAsync("Test Artist 1");
1717
await Expect(bar.UndoButton).ToBeEnabledAsync();
@@ -232,8 +232,8 @@ await Expect(TestPage.GetByRole(AriaRole.Table)).ToMatchAriaSnapshotAsync(@"- ta
232232
public async Task UndoRedo_ShouldRestoreTrackState_WhenModalEdit()
233233
{
234234
var bar = new AppBar(TestPage);
235-
await bar.GotoAsync();
236-
var detailView = new DetailView(TestPage, DeviceName != null);
235+
var detailView = new DetailView(TestPage, DeviceName != null);
236+
await detailView.GotoAsync();
237237
await detailView.AddTrackAsync();
238238
await detailView.SelectTracksAsync([1]);
239239
await detailView.EditTracksModalAsync("Test Track Artist 1", "Test Track Title 1", "00:02:23", ["channel audio (4CH)", "Serial copy management system"]);

‎AudioCuesheetEditor.End2EndTests/Tests/Smartphone/BasicTestSmartphone.cs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public async Task Audiofile_ShouldBeRenamed_WhenEditingFilename()
4141
public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
4242
{
4343
var bar = new AppBar(TestPage);
44-
await bar.GotoAsync();
44+
var detailView = new DetailView(TestPage, DeviceName != null);
45+
await detailView.GotoAsync();
4546
await bar.OpenSettingsAsync();
4647
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Settings" })).ToBeVisibleAsync();
4748
}
@@ -50,7 +51,8 @@ public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
5051
public async Task ChangeLanguage_ShouldShowGermanHeadings_WhenGermanIsSelected()
5152
{
5253
var bar = new AppBar(TestPage);
53-
await bar.GotoAsync();
54+
var detailView = new DetailView(TestPage, DeviceName != null);
55+
await detailView.GotoAsync();
5456
await bar.ChangeLanguageAsync("German (Germany)");
5557
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Abschnitte" })).ToBeVisibleAsync();
5658
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Allgemeine Informationen" })).ToBeVisibleAsync();

‎AudioCuesheetEditor.End2EndTests/Tests/Smartphone/TracingTestSmartphone.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ public class TracingTestSmartphone : PlaywrightTestBase
1212
public async Task UndoRedo_ShouldRestoreTrackState_WhenUndoAndRedoAreUsed()
1313
{
1414
var bar = new AppBar(TestPage);
15-
await bar.GotoAsync();
1615
var detailView = new DetailView(TestPage, DeviceName != null);
16+
await detailView.GotoAsync();
1717
await detailView.AddTrackAsync();
1818
await detailView.EditTrackAsync("Test Artist 1");
1919
await Expect(bar.UndoButton).ToBeEnabledAsync();
@@ -128,8 +128,8 @@ await Expect(TestPage.GetByRole(AriaRole.Table)).ToMatchAriaSnapshotAsync(@"- ta
128128
public async Task UndoRedo_ShouldRestoreTrackState_WhenModalEdit()
129129
{
130130
var bar = new AppBar(TestPage);
131-
await bar.GotoAsync();
132-
var detailView = new DetailView(TestPage, DeviceName != null);
131+
var detailView = new DetailView(TestPage, DeviceName != null);
132+
await detailView.GotoAsync();
133133
await detailView.AddTrackAsync();
134134
await detailView.SelectTracksAsync([1]);
135135
await detailView.EditTracksModalAsync("Test Track Artist 1", "Test Track Title 1", "00:02:23", ["channel audio (4CH)", "Serial copy management system"]);

0 commit comments

Comments
 (0)