best practise corrections

Author: NeoCoderMatrix86

AudioCuesheetEditor.End2EndTests/Tests/Desktop/ExportTest.cs

@@ -38,7 +38,7 @@ public async Task DownloadCuesheet_GeneratesCuesheetFile_WhenCuesheetIsValid()
             var download = await downloadTask;
             using var stream = await download.CreateReadStreamAsync();
             using var reader = new StreamReader(stream);
-            var content = await reader.ReadToEndAsync(TestContext.CancellationTokenSource.Token);
+            var content = await reader.ReadToEndAsync(TestContext.CancellationToken);
             content = content.Replace("\n", Environment.NewLine);
             Assert.AreEqual(@"TITLE ""Cuesheet Title 1""
 PERFORMER ""Cuesheet Artist 1""
@@ -67,7 +67,7 @@ public async Task DownloadProject_GeneratesProjectFile_WhenCuesheetIsValidAsync(
             var download = await downloadTask;
             using var stream = await download.CreateReadStreamAsync();
             using var reader = new StreamReader(stream);
-            var content = await reader.ReadToEndAsync(TestContext.CancellationTokenSource.Token);
+            var content = await reader.ReadToEndAsync(TestContext.CancellationToken);
             Assert.AreEqual("{\"Tracks\":[{\"Position\":1,\"Artist\":\"Track Artist 1\",\"Title\":\"Track Title 1\",\"Begin\":\"00:00:00\",\"End\":\"00:05:48\",\"Flags\":[],\"IsLinkedToPreviousTrack\":true}],\"Artist\":\"Cuesheet Artist 1\",\"Title\":\"Cuesheet Title 1\",\"Audiofile\":{\"Name\":\"Kalimba.mp3\",\"Duration\":\"00:05:48\",\"AudioCodec\":{\"MimeType\":\"audio/mpeg\",\"FileExtension\":\".mp3\",\"Name\":\"AudioCodec MP3\"}},\"Sections\":[]}", content);
         }
 
@@ -89,7 +89,7 @@ public async Task DownloadText_GeneratesTextFile_WhenCuesheetIsValidAsync()
             var download = await downloadTask;
             using var stream = await download.CreateReadStreamAsync();
             using var reader = new StreamReader(stream);
-            var content = await reader.ReadToEndAsync(TestContext.CancellationTokenSource.Token);
+            var content = await reader.ReadToEndAsync(TestContext.CancellationToken);
             content = content.Replace("\n", Environment.NewLine);
             Assert.AreEqual(@"Cuesheet Artist 1 - Cuesheet Title 1
 Track Artist 1 - Track Title 1 00:00:00

AudioCuesheetEditor.End2EndTests/Tests/Smartphone/ExportTestSmartphone.cs

@@ -38,7 +38,7 @@ public async Task DownloadCuesheet_GeneratesCuesheetFile_WhenCuesheetIsValid()
             var download = await downloadTask;
             using var stream = await download.CreateReadStreamAsync();
             using var reader = new StreamReader(stream);
-            var content = await reader.ReadToEndAsync(TestContext.CancellationTokenSource.Token);
+            var content = await reader.ReadToEndAsync(TestContext.CancellationToken);
             content = content.Replace("\n", Environment.NewLine);
             Assert.AreEqual(@"TITLE ""Cuesheet Title 1""
 PERFORMER ""Cuesheet Artist 1""
@@ -67,7 +67,7 @@ public async Task DownloadProject_GeneratesProjectFile_WhenCuesheetIsValidAsync(
             var download = await downloadTask;
             using var stream = await download.CreateReadStreamAsync();
             using var reader = new StreamReader(stream);
-            var content = await reader.ReadToEndAsync(TestContext.CancellationTokenSource.Token);
+            var content = await reader.ReadToEndAsync(TestContext.CancellationToken);
             Assert.AreEqual("{\"Tracks\":[{\"Position\":1,\"Artist\":\"Track Artist 1\",\"Title\":\"Track Title 1\",\"Begin\":\"00:00:00\",\"End\":\"00:05:48\",\"Flags\":[],\"IsLinkedToPreviousTrack\":true}],\"Artist\":\"Cuesheet Artist 1\",\"Title\":\"Cuesheet Title 1\",\"Audiofile\":{\"Name\":\"Kalimba.mp3\",\"Duration\":\"00:05:48\",\"AudioCodec\":{\"MimeType\":\"audio/mpeg\",\"FileExtension\":\".mp3\",\"Name\":\"AudioCodec MP3\"}},\"Sections\":[]}", content);
         }
 
@@ -89,7 +89,7 @@ public async Task DownloadText_GeneratesTextFile_WhenCuesheetIsValidAsync()
             var download = await downloadTask;
             using var stream = await download.CreateReadStreamAsync();
             using var reader = new StreamReader(stream);
-            var content = await reader.ReadToEndAsync(TestContext.CancellationTokenSource.Token);
+            var content = await reader.ReadToEndAsync(TestContext.CancellationToken);
             content = content.Replace("\n", Environment.NewLine);
             Assert.AreEqual(@"Cuesheet Artist 1 - Cuesheet Title 1
 Track Artist 1 - Track Title 1 00:00:00

AudioCuesheetEditor/Services/UI/ApplicationOptionsTimeSpanParser.cs

@@ -26,7 +26,7 @@ public class ApplicationOptionsTimeSpanParser
         private readonly ILocalStorageOptionsProvider _localStorageOptionsProvider;
 
         private ApplicationOptions? applicationOptions;
-        private Task? _initTask;
+        private readonly Task? _initTask;
         private bool disposedValue;
 
         public ApplicationOptionsTimeSpanParser(ILocalStorageOptionsProvider localStorageOptionsProvider)