feat: update priority field range for letter variants to 1-99

Author: m-houston

packages/events/src/domain/letter-variant.ts

@@ -44,10 +44,10 @@ export const $LetterVariant = z
           "This is used to restrict a particular variant to a single supplier, " +
           "for example individual admail campaigns.",
       }),
-    priority: z.int().min(1).max(100).default(50).meta({
+    priority: z.int().min(1).max(99).default(50).meta({
       title: "Priority",
       description:
-        "Integer priority used to order letters for dispatch to suppliers on a 1 to 100 scale, where lower values indicate higher priority. Defaults to 50 when omitted.",
+        "Integer priority used to order letters for dispatch to suppliers on a 1 to 99 scale, where lower values indicate higher priority. Defaults to 50 when omitted.",
     }),
     packSpecificationIds: z.array(idRef($PackSpecification)).nonempty().meta({
       title: "Pack Specifications",

packages/events/src/events/__tests__/letter-variant-events.test.ts

@@ -221,13 +221,13 @@ describe("LetterVariant Events", () => {
         ...validProdEvent,
         data: {
           ...validProdEvent.data,
-          priority: 100,
+          priority: 99,
         },
       };
 
       const result = $LetterVariantEvent.safeParse(eventAtLowestPriority);
       expect(result.success).toBe(true);
-      expect(result.data?.data.priority).toBe(100);
+      expect(result.data?.data.priority).toBe(99);
     });
 
     it("should reject priority lower than the allowed range", () => {
@@ -248,7 +248,7 @@ describe("LetterVariant Events", () => {
         ...validProdEvent,
         data: {
           ...validProdEvent.data,
-          priority: 101,
+          priority: 100,
         },
       };
 

packages/file-store/src/__tests__/config-store-validator.test.ts

@@ -14,7 +14,7 @@ jest.mock("@nhsdigital/nhs-notify-event-schemas-supplier-config", () => {
     }),
     $LetterVariant: z.object({
       id: z.string(),
-      priority: z.number().int().min(1).max(100).default(50),
+      priority: z.number().int().min(1).max(99).default(50),
       packSpecificationIds: z.array(z.string()).min(1),
     }),
     $PackSpecification: z.object({
@@ -171,7 +171,7 @@ describe("validateConfigStore", () => {
       records: [
         makeRecord("letter-variant", "lv-1", {
           id: "lv-1",
-          priority: 101,
+          priority: 100,
           packSpecificationIds: ["pack-spec-1"],
         }),
       ],