Skip to content

Commit e38d5e3

Browse files
committed
CCM-16068: Additional pnpm migration changes
1 parent 4bc5ddd commit e38d5e3

7 files changed

Lines changed: 35 additions & 34 deletions

File tree

.github/actions/build-docs/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ runs:
1212
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
1313
with:
1414
node-version: 18
15-
- name: Npm cli install
15+
- name: Install docs node dependencies
1616
working-directory: ./docs
17-
run: npm ci
17+
run: pnpm --ignore-workspace install --frozen-lockfile
1818
shell: bash
1919
- name: Setup Ruby
2020
uses: ruby/setup-ruby@3783f195e29b74ae398d7caca108814bbafde90e # v1.180.1

docs/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ h help:
88
@egrep '^\S|^$$' Makefile
99

1010
install:
11-
npm install
11+
pnpm --ignore-workspace install --frozen-lockfile
1212
bundle config set --local path vendor/bundle
1313
bundle install
1414

@@ -20,10 +20,10 @@ $(if $(BASE_URL),-- --baseurl $(BASE_URL),-- --baseurl "")
2020
endef
2121

2222
build: version
23-
npm run build $(baseurlparam)
23+
pnpm --ignore-workspace run build $(baseurlparam)
2424

2525
debug: version
26-
npm run debug
26+
pnpm --ignore-workspace run debug
2727

2828
version:
2929
touch _config.version.yml

docs/_config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ include:
9494
- .version
9595
- version.json
9696
exclude:
97-
- package-lock.json
97+
- pnpm-lock.yaml
9898
- package.json
9999
- Makefile
100100
# - .sass-cache/

docs/package-lock.json

Lines changed: 0 additions & 22 deletions
This file was deleted.

docs/pnpm-lock.yaml

Lines changed: 23 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scripts/config/.repository-template-sync-ignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ eslint.config.mjs
2525
infrastructure/terraform/components/
2626
lambdas/example-lambda/
2727
package-lock.json
28+
pnpm-lock.yaml
2829
package.json
2930
scripts/**/examples/
3031
scripts/terraform/terraform.mk

src/jekyll-devcontainer/Makefile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
build:
22
$(MAKE) -C ../../ version
3-
npm install -g @devcontainers/cli
43
ver=$$(head -n 1 ../../.version 2> /dev/null || echo unknown); \
54
verb=$$(echo $$ver | sed 's/\+.*//'); \
65
echo "version: $$verb"; \
7-
BUILDKIT_PROGRESS=plain devcontainer build --workspace-folder ./src --image-name "ghcr.io/nhsdigital/nhs-notify-template-repository:$$verb"
6+
BUILDKIT_PROGRESS=plain pnpm dlx @devcontainers/cli build --workspace-folder ./src --image-name "ghcr.io/nhsdigital/nhs-notify-template-repository:$$verb"
87

98
publish:
109
ver=$$(head -n 1 ../../.version 2> /dev/null || echo unknown); \
@@ -15,7 +14,7 @@ publish:
1514
docker push "ghcr.io/nhsdigital/nhs-notify-template-repository:latest"
1615

1716
debug:
18-
devcontainer up --workspace-folder ./src
19-
devcontainer exec --workspace-folder ./src ls -la ./.devcontainer
20-
devcontainer exec --workspace-folder ./src cat ./.devcontainer/packages.txt
21-
devcontainer exec --workspace-folder ./src ./.devcontainer/check.sh
17+
pnpm dlx @devcontainers/cli up --workspace-folder ./src
18+
pnpm dlx @devcontainers/cli exec --workspace-folder ./src ls -la ./.devcontainer
19+
pnpm dlx @devcontainers/cli exec --workspace-folder ./src cat ./.devcontainer/packages.txt
20+
pnpm dlx @devcontainers/cli exec --workspace-folder ./src ./.devcontainer/check.sh

0 commit comments

Comments
 (0)