Skip to content

Commit ffbc2ee

Browse files
CCM-14974: Readd test and change it to message skipped
1 parent 7bac1fb commit ffbc2ee

2 files changed

Lines changed: 16 additions & 15 deletions

File tree

tests/playwright/digital-letters-component-tests/report-generator.component.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
prerequisiteAssertFirehoseEventsInS3,
1111
prerequisiteTriggerAndAssertGlueTableRefresh,
1212
publishEventForScenario,
13+
publishEventNotInReports,
1314
publishGenerateReport,
1415
} from 'helpers/report-helpers';
1516

@@ -173,6 +174,8 @@ test.describe('Digital Letters - Report Generator', () => {
173174
console.log(`Using senderId: ${senderId}`);
174175

175176
for (const scenario of scenarios) publishEventForScenario(scenario);
177+
// Publish an event that should not appear in the report
178+
await publishEventNotInReports(senderId);
176179
// At this stage we published all the events used for test data.
177180
// Asserts step 1.2
178181
await prerequisiteAssertFirehoseEventsInS3(senderId);

tests/playwright/helpers/report-helpers.ts

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ import {
1414
FileQuarantined,
1515
GenerateReport,
1616
ItemDequeued,
17-
MESHInboxMessageDownloaded,
1817
MessageRequestRejected,
18+
MessageRequestSkipped,
1919
PDMResourceRetriesExceeded,
2020
PDMResourceSubmissionRejected,
2121
PrintLetterTransitioned,
2222
} from 'digital-letters-events';
2323
import generateReportValidator from 'digital-letters-events/GenerateReport.js';
2424
import digitalLetterReadValidator from 'digital-letters-events/DigitalLetterRead.js';
25-
import messageDownloadedValidator from 'digital-letters-events/MESHInboxMessageDownloaded.js';
2625
import itemDequeuedValidator from 'digital-letters-events/ItemDequeued.js';
26+
import messageRequestSkippedValidator from 'digital-letters-events/MessageRequestSkipped.js';
2727
import printLetterTransitionedValidator from 'digital-letters-events/PrintLetterTransitioned.js';
2828
import pdmResourceSubmissionRejectedValidator from 'digital-letters-events/PDMResourceSubmissionRejected.js';
2929
import pdmResourceRetriesExceededValidator from 'digital-letters-events/PDMResourceRetriesExceeded.js';
@@ -272,35 +272,33 @@ export async function publishGenerateReport(
272272
* Publishes an event which should not be included in the report, to prove that only the expected events are included in the report.
273273
*/
274274
export async function publishEventNotInReports(senderId: string) {
275-
const downloadedEventId = uuidv4();
276-
const downloadedEventTime = new Date().toISOString();
277-
await eventPublisher.sendEvents<MESHInboxMessageDownloaded>(
275+
const skippedEventId = uuidv4();
276+
const skippedEventTime = new Date().toISOString();
277+
await eventPublisher.sendEvents<MessageRequestSkipped>(
278278
[
279279
{
280-
id: downloadedEventId,
280+
id: skippedEventId,
281281
specversion: '1.0',
282282
source:
283-
'/nhs/england/notify/production/primary/data-plane/digitalletters/mesh',
283+
'/nhs/england/notify/production/primary/data-plane/digitalletters/messages',
284284
subject:
285285
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
286-
type: 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
287-
time: downloadedEventTime,
288-
recordedtime: downloadedEventTime,
286+
type: 'uk.nhs.notify.digital.letters.messages.request.skipped.v1',
287+
time: skippedEventTime,
288+
recordedtime: skippedEventTime,
289289
severitynumber: 2,
290290
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
291291
datacontenttype: 'application/json',
292292
dataschema:
293-
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-mesh-inbox-message-downloaded-data.schema.json',
293+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-message-request-skipped-data.schema.json',
294294
severitytext: 'INFO',
295295
data: {
296-
meshMessageId: '12345',
297-
messageUri: `https://example.com/ttl/resource/${downloadedEventId}`,
298-
messageReference: 'component-test-messageDownloaded',
296+
messageReference: 'component-test-messageSkipped',
299297
senderId,
300298
},
301299
},
302300
],
303-
messageDownloadedValidator,
301+
messageRequestSkippedValidator,
304302
);
305303
}
306304

0 commit comments

Comments
 (0)