Skip to content

Commit f5c7d36

Browse files
CCM-15019: missing fields
1 parent 2e3870a commit f5c7d36

11 files changed

Lines changed: 32 additions & 3 deletions

File tree

lambdas/core-notifier-lambda/src/__tests__/constants.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ export const validPdmEvent: PDMResourceAvailable = {
6363
plane: 'data',
6464
dataschemaversion: '1.0.0',
6565
source: '/nhs/england/notify/development/dev-12345/digitalletters/pdm',
66+
dataschema:
67+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-pdm-resource-available-data.schema.json',
6668
specversion: '1.0',
6769
type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
6870
time: '2025-12-15T10:00:00Z',

lambdas/mesh-acknowledge/mesh_acknowledge/__tests__/fixtures.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ def create_downloaded_event_dict(event_id: str) -> Dict[str, str | int | Dict[st
2929
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/'
3030
'digital-letters-mesh-inbox-message-downloaded-data.schema.json'
3131
),
32+
"dataschemaversion": '1.0.0',
3233
"datacategory": "non-sensitive",
3334
"dataclassification": "public",
3435
"dataregulation": "GDPR",

lambdas/mesh-download/mesh_download/__tests__/test_processor.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ def create_valid_cloud_event():
4343
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
4444
'plane': 'data',
4545
'dataschemaversion': '1.0.0',
46+
'datacontenttype': 'application/json',
4647
'time': '2023-01-01T12:00:00Z',
4748
'recordedtime': '2023-01-01T12:00:00Z',
4849
'severitynumber': 2,
@@ -165,7 +166,8 @@ def test_process_sqs_message_success(self, mock_datetime):
165166
assert published_event['subject'] == 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000'
166167
assert published_event['time'] == '2025-11-19T15:30:45+00:00'
167168
assert published_event['plane'] == 'data'
168-
assert published_event['dataschemaversion'] == '1.0'
169+
assert published_event['dataschemaversion'] == '1.0.0'
170+
assert published_event['datacontenttype'] == 'application/json'
169171
assert 'id' in published_event
170172
assert 'tracestate' not in published_event
171173
assert 'partitionkey' not in published_event

lambdas/move-scanned-files-lambda/src/__tests__/apis/sqs-handler.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ describe('sqs-handler', () => {
7070
source: '/test',
7171
plane: 'data',
7272
dataschemaversion: '1.0.0',
73+
datacontenttype: 'application/json',
74+
dataschema:
75+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-safe-data.schema.json',
7376
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
7477
time: '2024-01-01T00:00:00Z',
7578
data: {
@@ -110,7 +113,10 @@ describe('sqs-handler', () => {
110113
id: 'test-id-1',
111114
source: '/test',
112115
plane: 'data',
116+
dataschema:
117+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-safe-data.schema.json',
113118
dataschemaversion: '1.0.0',
119+
datacontenttype: 'application/json',
114120
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
115121
time: '2024-01-01T00:00:00Z',
116122
data: {
@@ -130,7 +136,10 @@ describe('sqs-handler', () => {
130136
id: 'test-id-2',
131137
source: '/test',
132138
plane: 'data',
139+
dataschema:
140+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-quarantined-data.schema.json',
133141
dataschemaversion: '1.0.0',
142+
datacontenttype: 'application/json',
134143
type: 'uk.nhs.notify.digital.letters.print.file.quarantined.v1',
135144
time: '2024-01-01T00:00:00Z',
136145
data: {
@@ -198,6 +207,9 @@ describe('sqs-handler', () => {
198207
source: '/test',
199208
plane: 'data',
200209
dataschemaversion: '1.0.0',
210+
datacontenttype: 'application/json',
211+
dataschema:
212+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-safe-data.schema.json',
201213
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
202214
time: '2024-01-01T00:00:00Z',
203215
data: {

lambdas/move-scanned-files-lambda/src/__tests__/domain/mapper.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ describe('mapper', () => {
4545
subject: `customer/${senderId}/recipient/${messageReference}`,
4646
source: '/nhs/england/notify/production/primary/digitalletters/print',
4747
plane: 'data',
48+
dataschema:
49+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-safe-data.schema.json',
4850
dataschemaversion: '1.0.0',
4951
datacontenttype: 'application/json',
5052
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
@@ -102,6 +104,8 @@ describe('mapper', () => {
102104
id: 'mocked-uuid-12345',
103105
subject: `customer/${senderId}/recipient/${messageReference}`,
104106
plane: 'data',
107+
dataschema:
108+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-quarantined-data.schema.json',
105109
dataschemaversion: '1.0.0',
106110
datacontenttype: 'application/json',
107111
source: '/nhs/england/notify/production/primary/digitalletters/print',

lambdas/move-scanned-files-lambda/src/domain/mapper.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ export function createFileSafeEvent(
1212
id: randomUUID(),
1313
subject: `customer/${senderId}/recipient/${messageReference}`,
1414
plane: 'data',
15+
dataschema:
16+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-safe-data.schema.json',
1517
dataschemaversion: '1.0.0',
1618
datacontenttype: 'application/json',
1719
source: '/nhs/england/notify/production/primary/digitalletters/print', // Note CCM-13892.
@@ -40,6 +42,8 @@ export function createFileQuarantinedEvent(
4042
id: randomUUID(),
4143
subject: `customer/${senderId}/recipient/${messageReference}`,
4244
plane: 'data',
45+
dataschema:
46+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-file-quarantined-data.schema.json',
4347
dataschemaversion: '1.0.0',
4448
datacontenttype: 'application/json',
4549
source: '/nhs/england/notify/production/primary/digitalletters/print', // Note CCM-13892.

lambdas/print-sender-lambda/src/__tests__/apis/sqs-trigger-lambda.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const createValidEvent = (overrides = {}): PDFAnalysed => ({
3030
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-pdf-analysed-data.schema.json',
3131
plane: 'data',
3232
dataschemaversion: '1.0.0',
33+
datacontenttype: 'application/json',
3334
source: '/nhs/england/notify/production/primary/digitalletters/print',
3435
specversion: '1.0',
3536
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',

lambdas/print-sender-lambda/src/__tests__/app/print-sender.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe('PrintSender', () => {
1919
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
2020
plane: 'data',
2121
dataschemaversion: '1.0.0',
22+
datacontenttype: 'application/json',
2223
specversion: '1.0',
2324
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
2425
severitynumber: 2,

lambdas/report-generator/src/__tests__/app/report-generator.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ describe('ReportGenerator', () => {
4848
datacontenttype: 'application/json',
4949
subject: 'customer/5661de82-7453-44a1-9922-e0c98e5411c1',
5050
plane: 'data',
51+
dataschema:
52+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-reporting-generate-report-data.schema.json',
5153
dataschemaversion: '1.0.0',
5254
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
5355
recordedtime: '2025-12-15T10:00:00Z',

lambdas/report-sender/report_sender/__tests__/test_report_sender_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ def test_publish_report_sent_event_success(
246246
assert event['data']['meshMailboxReportsId'] == mesh_mailbox_reports_id
247247
assert event['specversion'] == '1.0'
248248
assert event['plane'] == 'data'
249-
assert event['dataschemaversion'] == '1.0'
249+
assert event['dataschemaversion'] == '1.0.0'
250250
assert event['datacontenttype'] == 'application/json'
251251
assert 'id' in event
252252
assert 'time' in event

0 commit comments

Comments
 (0)