CCM-14325: Make PDM uploader use PDM mock

gareth-allan · gareth-allan · commit e6ba613fdafc · 2026-03-06T13:37:31.000Z
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_deployment_pdm_mock.tf b/infrastructure/terraform/components/dl/aws_api_gateway_deployment_pdm_mock.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_deployment" "pdm_mock" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   depends_on = [
     aws_api_gateway_integration.create_document_reference,
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_integration_create_document_reference.tf b/infrastructure/terraform/components/dl/aws_api_gateway_integration_create_document_reference.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_integration" "create_document_reference" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id = aws_api_gateway_rest_api.pdm_mock[0].id
   resource_id = aws_api_gateway_resource.document_reference[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_integration_get_document_reference.tf b/infrastructure/terraform/components/dl/aws_api_gateway_integration_get_document_reference.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_integration" "get_document_reference" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id = aws_api_gateway_rest_api.pdm_mock[0].id
   resource_id = aws_api_gateway_resource.document_reference_id[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_method_create_document_reference.tf b/infrastructure/terraform/components/dl/aws_api_gateway_method_create_document_reference.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_method" "create_document_reference" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id   = aws_api_gateway_rest_api.pdm_mock[0].id
   resource_id   = aws_api_gateway_resource.document_reference[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_method_get_document_reference.tf b/infrastructure/terraform/components/dl/aws_api_gateway_method_get_document_reference.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_method" "get_document_reference" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id   = aws_api_gateway_rest_api.pdm_mock[0].id
   resource_id   = aws_api_gateway_resource.document_reference_id[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_resource_document_reference.tf b/infrastructure/terraform/components/dl/aws_api_gateway_resource_document_reference.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_resource" "document_reference" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id = aws_api_gateway_rest_api.pdm_mock[0].id
   parent_id   = aws_api_gateway_resource.r4[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_resource_document_reference_id.tf b/infrastructure/terraform/components/dl/aws_api_gateway_resource_document_reference_id.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_resource" "document_reference_id" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id = aws_api_gateway_rest_api.pdm_mock[0].id
   parent_id   = aws_api_gateway_resource.document_reference[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_resource_fhir.tf b/infrastructure/terraform/components/dl/aws_api_gateway_resource_fhir.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_resource" "fhir" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id = aws_api_gateway_rest_api.pdm_mock[0].id
   parent_id   = aws_api_gateway_resource.patient_data_manager[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_resource_patient_data_manager.tf b/infrastructure/terraform/components/dl/aws_api_gateway_resource_patient_data_manager.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_resource" "patient_data_manager" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id = aws_api_gateway_rest_api.pdm_mock[0].id
   parent_id   = aws_api_gateway_rest_api.pdm_mock[0].root_resource_id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_resource_r4.tf b/infrastructure/terraform/components/dl/aws_api_gateway_resource_r4.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_resource" "r4" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   rest_api_id = aws_api_gateway_rest_api.pdm_mock[0].id
   parent_id   = aws_api_gateway_resource.fhir[0].id
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_rest_api_pdm_mock.tf b/infrastructure/terraform/components/dl/aws_api_gateway_rest_api_pdm_mock.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_rest_api" "pdm_mock" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   name        = "${var.project}-${var.environment}-pdm-mock"
   description = "PDM Mock API for testing integration with Patient Data Manager"
diff --git a/infrastructure/terraform/components/dl/aws_api_gateway_stage_pdm_mock.tf b/infrastructure/terraform/components/dl/aws_api_gateway_stage_pdm_mock.tf
@@ -1,5 +1,5 @@
 resource "aws_api_gateway_stage" "pdm_mock" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   deployment_id = aws_api_gateway_deployment.pdm_mock[0].id
   rest_api_id   = aws_api_gateway_rest_api.pdm_mock[0].id
diff --git a/infrastructure/terraform/components/dl/aws_cloudwatch_log_group_pdm_mock_gateway.tf b/infrastructure/terraform/components/dl/aws_cloudwatch_log_group_pdm_mock_gateway.tf
@@ -1,5 +1,5 @@
 resource "aws_cloudwatch_log_group" "pdm_mock_gateway" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   name              = "/aws/apigateway/${var.project}-${var.environment}-pdm-mock"
   retention_in_days = var.log_retention_in_days
diff --git a/infrastructure/terraform/components/dl/aws_lambda_permission_pdm_mock_gateway.tf b/infrastructure/terraform/components/dl/aws_lambda_permission_pdm_mock_gateway.tf
@@ -1,5 +1,5 @@
 resource "aws_lambda_permission" "pdm_mock_gateway" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   statement_id  = "AllowAPIGatewayInvoke"
   action        = "lambda:InvokeFunction"
diff --git a/infrastructure/terraform/components/dl/locals.tf b/infrastructure/terraform/components/dl/locals.tf
@@ -4,7 +4,7 @@ locals {
   apim_keystore_s3_bucket              = "nhs-${var.aws_account_id}-${var.region}-${var.environment}-${var.component}-static-assets"
   apim_private_key_ssm_parameter_name  = "/${var.component}/${var.environment}/apim/private_key"
   aws_lambda_functions_dir_path        = "../../../../lambdas"
-  deploy_pdm_mock                      = var.enable_pdm_mock
+  pdm_url                              = var.enable_pdm_mock ? aws_api_gateway_stage.pdm_mock[0].invoke_url : var.apim_base_url
   firehose_output_path_prefix          = "kinesis-firehose-output"
   log_destination_arn                  = "arn:aws:logs:${var.region}:${var.shared_infra_account_id}:destination:nhs-main-obs-firehose-logs"
   mock_mesh_endpoint                   = "s3://${module.s3bucket_non_pii_data.bucket}/mock-mesh"
diff --git a/infrastructure/terraform/components/dl/module_lambda_pdm_mock.tf b/infrastructure/terraform/components/dl/module_lambda_pdm_mock.tf
@@ -1,5 +1,5 @@
 module "pdm_mock" {
-  count  = local.deploy_pdm_mock ? 1 : 0
+  count  = var.enable_pdm_mock ? 1 : 0
   source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip"
 
   function_name = "pdm-mock"
@@ -37,7 +37,7 @@ module "pdm_mock" {
 }
 
 data "aws_iam_policy_document" "pdm_mock" {
-  count = local.deploy_pdm_mock ? 1 : 0
+  count = var.enable_pdm_mock ? 1 : 0
 
   statement {
     sid    = "KMSPermissions"
diff --git a/infrastructure/terraform/components/dl/module_lambda_pdm_poll.tf b/infrastructure/terraform/components/dl/module_lambda_pdm_poll.tf
@@ -35,7 +35,7 @@ module "pdm_poll" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = {
-    "APIM_BASE_URL"                        = local.deploy_pdm_mock ? aws_api_gateway_stage.pdm_mock[0].invoke_url : var.apim_base_url
+    "APIM_BASE_URL"                        = local.pdm_url
     "APIM_ACCESS_TOKEN_SSM_PARAMETER_NAME" = local.apim_access_token_ssm_parameter_name
     "EVENT_PUBLISHER_EVENT_BUS_ARN"        = aws_cloudwatch_event_bus.main.arn
     "EVENT_PUBLISHER_DLQ_URL"              = module.sqs_event_publisher_errors.sqs_queue_url
diff --git a/infrastructure/terraform/components/dl/module_lambda_pdm_uploader.tf b/infrastructure/terraform/components/dl/module_lambda_pdm_uploader.tf
@@ -35,7 +35,7 @@ module "pdm_uploader" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = {
-    "APIM_BASE_URL"                        = var.apim_base_url
+    "APIM_BASE_URL"                        = local.pdm_url
     "APIM_ACCESS_TOKEN_SSM_PARAMETER_NAME" = local.apim_access_token_ssm_parameter_name
     "EVENT_PUBLISHER_EVENT_BUS_ARN"        = aws_cloudwatch_event_bus.main.arn
     "EVENT_PUBLISHER_DLQ_URL"              = module.sqs_event_publisher_errors.sqs_queue_url
