CCM-15297: Don't use double quotes in TF when they're not necessary

Author: simonlabarere

infrastructure/terraform/components/dl/module_lambda_mesh_acknowledge.tf

@@ -40,8 +40,8 @@ module "mesh_acknowledge" {
     EVENT_PUBLISHER_DLQ_URL       = module.sqs_event_publisher_errors.sqs_queue_url
     EVENT_PUBLISHER_EVENT_BUS_ARN = aws_cloudwatch_event_bus.main.arn
     MOCK_MESH_BUCKET              = module.s3bucket_non_pii_data.bucket
-    SSM_MESH_PREFIX               = "${local.ssm_mesh_prefix}"
-    SSM_SENDERS_PREFIX            = "${local.ssm_senders_prefix}"
+    SSM_MESH_PREFIX               = local.ssm_mesh_prefix
+    SSM_SENDERS_PREFIX            = local.ssm_senders_prefix
     USE_MESH_MOCK                 = var.enable_mock_mesh ? "true" : "false"
   }
 

infrastructure/terraform/components/dl/module_lambda_mesh_download.tf

@@ -44,8 +44,8 @@ module "mesh_download" {
     EVENT_PUBLISHER_DLQ_URL        = module.sqs_event_publisher_errors.sqs_queue_url
     EVENT_PUBLISHER_EVENT_BUS_ARN  = aws_cloudwatch_event_bus.main.arn
     PII_BUCKET                     = module.s3bucket_pii_data.bucket
-    SSM_MESH_PREFIX                = "${local.ssm_mesh_prefix}"
-    SSM_SENDERS_PREFIX             = "${local.ssm_senders_prefix}"
+    SSM_MESH_PREFIX                = local.ssm_mesh_prefix
+    SSM_SENDERS_PREFIX             = local.ssm_senders_prefix
     USE_MESH_MOCK                  = var.enable_mock_mesh ? "true" : "false"
   }
 

infrastructure/terraform/components/dl/module_lambda_mesh_poll.tf

@@ -45,8 +45,8 @@ module "mesh_poll" {
     MAXIMUM_RUNTIME_MILLISECONDS        = "240000" # 4 minutes (Lambda has 5 min timeout)
     POLLING_METRIC_NAME                 = "mesh-poll-successful-polls"
     POLLING_METRIC_NAMESPACE            = "dl-mesh-poll"
-    SSM_MESH_PREFIX                     = "${local.ssm_mesh_prefix}"
-    SSM_SENDERS_PREFIX                  = "${local.ssm_senders_prefix}"
+    SSM_MESH_PREFIX                     = local.ssm_mesh_prefix
+    SSM_SENDERS_PREFIX                  = local.ssm_senders_prefix
     USE_MESH_MOCK                       = var.enable_mock_mesh ? "true" : "false"
   }
 

infrastructure/terraform/components/dl/module_lambda_report_sender.tf

@@ -42,8 +42,8 @@ module "report_sender" {
     EVENT_PUBLISHER_DLQ_URL        = module.sqs_event_publisher_errors.sqs_queue_url
     EVENT_PUBLISHER_EVENT_BUS_ARN  = aws_cloudwatch_event_bus.main.arn
     MOCK_MESH_BUCKET               = module.s3bucket_non_pii_data.bucket
-    SSM_MESH_PREFIX                = "${local.ssm_mesh_prefix}"
-    SSM_SENDERS_PREFIX             = "${local.ssm_senders_prefix}"
+    SSM_MESH_PREFIX                = local.ssm_mesh_prefix
+    SSM_SENDERS_PREFIX             = local.ssm_senders_prefix
     USE_MESH_MOCK                  = var.enable_mock_mesh ? "true" : "false"
   }