CCM-14615 Unit test quickening (#249)

Author: Ian-Hodges

.github/workflows/stage-2-test.yaml

@@ -99,12 +99,30 @@ jobs:
         with:
           node-version: ${{ inputs.nodejs_version }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: "Install dependencies"
+        run: npm ci
       - name: "Setup Python"
         uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
         with:
           python-version: ${{ inputs.python_version }}
           cache: 'pip'
           cache-dependency-path: '**/requirements*.txt'
+      - name: "Cache generated dependencies"
+        id: schema-cache
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
+        with:
+          path: |
+            schemas/digital-letters/
+            output/digital-letters/
+            src/digital-letters-events/types/
+            src/digital-letters-events/validators/
+            src/digital-letters-events/digital_letters_events/models/
+            src/digital-letters-events/guard-functions/
+          key: generated-deps-${{ runner.os }}-${{ hashFiles('src/cloudevents/**', 'src/typescript-schema-generator/**', 'src/python-schema-generator/**') }}
+      - name: "Generate dependencies"
+        if: steps.schema-cache.outputs.cache-hit != 'true'
+        run: |
+          npm run generate-dependencies
       - name: "Run unit test suite"
         run: |
           make test-unit

.gitignore

@@ -14,6 +14,7 @@ version.json
 
 # Don't track ephemeral local build files
 target/
+.turbo
 
 # Python build artifacts
 *.egg-info/

jest.config.base.ts

@@ -55,4 +55,7 @@ export const baseJestConfig: Config = {
   testEnvironment: 'node',
 
   moduleDirectories: ['node_modules', 'src'],
+
+  // Turbo now handles parallel running
+  maxWorkers: 1,
 };

lambdas/key-generation/src/__tests__/refresh-keystores.test.ts

@@ -348,6 +348,35 @@ describe('cleanAndRefreshKeystores', () => {
     });
   });
 
+  it('Does not update youngestKeyDate if first key is already newer than second key', async () => {
+    const {
+      mockGenerateNewKey,
+      mockUploadPublicKeystoreToS3,
+      mockValidatePrivateKey,
+    } = setupMocks(['2024-07-15', '2024-06-01']);
+
+    const now = new Date('2024-09-01');
+
+    // simulate multiple keys where the first key is newer — youngestKeyDate should NOT be updated
+    mockValidatePrivateKey
+      .mockResolvedValueOnce({
+        valid: true,
+        keyJwk: { kid: 'key1' } as JWK.Key,
+        keyDate: new Date('2024-07-15'), // newer key first
+      })
+      .mockResolvedValueOnce({
+        valid: true,
+        keyJwk: { kid: 'key2' } as JWK.Key,
+        keyDate: new Date('2024-06-01'), // older key second — should not update youngestKeyDate
+      });
+
+    await cleanAndRefreshKeystores({ now });
+
+    expect(mockValidatePrivateKey).toHaveBeenCalledTimes(2);
+    expect(mockGenerateNewKey).toHaveBeenCalled();
+    expect(mockUploadPublicKeystoreToS3).toHaveBeenCalled();
+  });
+
   it('Runs successfully when updating youngestKeyDate if second key is newer', async () => {
     const {
       mockGenerateNewKey,

lambdas/mesh-acknowledge/pytest.ini

@@ -7,6 +7,7 @@ addopts = -v --tb=short
 
 [coverage:run]
 relative_files = True
+data_file = lambdas/mesh-acknowledge/.coverage
 omit =
     */mesh_acknowledge/__tests__/*
     */test_*.py

lambdas/mesh-download/pytest.ini

@@ -7,6 +7,7 @@ addopts = -v --tb=short
 
 [coverage:run]
 relative_files = True
+data_file = lambdas/mesh-download/.coverage
 omit =
     */tests/*
     */test_*.py

lambdas/mesh-poll/pytest.ini

@@ -7,6 +7,7 @@ addopts = -v --tb=short
 
 [coverage:run]
 relative_files = True
+data_file = lambdas/mesh-poll/.coverage
 omit =
     */mesh_poll/__tests__/*
     */test_*.py

lambdas/report-sender/pytest.ini

@@ -7,6 +7,7 @@ addopts = -v --tb=short
 
 [coverage:run]
 relative_files = True
+data_file = lambdas/report-sender/.coverage
 omit =
     */report_sender/__tests__/*
     */test_*.py

package-lock.json

@@ -32,6 +32,7 @@
     "ts-jest": "^29.4.5",
     "ts-node": "^10.9.2",
     "tsx": "^4.20.6",
+    "turbo": "^2.9.6",
     "typescript-eslint": "^8.46.1"
   },
   "name": "nhs-notify-digital-letters",
@@ -45,16 +46,16 @@
     "react": "^19.0.0",
     "test-exclude": "^8.0.0"
   },
+  "packageManager": "npm@11.6.1",
   "scripts": {
     "build-schemas": "make -C src/cloudevents/domains/digital-letters build-no-bundle publish-bundled-json",
     "clean": "npm run clean --workspaces --if-present",
-    "generate-dependencies": "npm run build-schemas && npm run generate-dependencies --workspaces --if-present && npm run generate-python-dependencies",
+    "generate-dependencies": "npm run build-schemas && turbo run generate-dependencies && npm run generate-python-dependencies",
     "generate-python-dependencies": "make -C src/python-schema-generator generate",
-    "lint": "npm run lint --workspaces",
-    "lint:fix": "npm run lint:fix --workspaces",
-    "start": "npm run start --workspace frontend",
-    "test:unit": "npm run test:unit --workspaces",
-    "typecheck": "npm run typecheck --workspaces"
+    "lint": "turbo run lint",
+    "lint:fix": "turbo run lint:fix",
+    "test:unit": "turbo run test:unit",
+    "typecheck": "turbo run typecheck"
   },
   "version": "0.0.1",
   "workspaces": [