CCM-12397: resolve sonar issues (#51)

lapenna-bjss · web-flow · commit af64e7a88791 · 2025-10-14T15:46:41.000+01:00
diff --git a/docs/_sass/color_schemes/ce.scss b/docs/_sass/color_schemes/ce.scss
@@ -32,13 +32,10 @@ section > h2 {
 .site-fork-warning {
   width: 100%;
   padding-left: 30px;
+  display: none;
   @include mq(lg) {
     width: $nav-width;
   }
-}
-
-.site-fork-warning {
-  display: none;
   @include mq(md) {
     display: block;
   }
@@ -78,8 +75,6 @@ $base-button-color: $grey-nhs-pale-grey;
 $nav-child-link-color: $grey-nhs-mid-grey;
 $body-heading-color: $blue-nhs-dark-blue;
 
-//$body-font-family: Frutiger, Arial;
-
 
 .text-nhs-mid-grey {
     color: $grey-nhs-mid-grey !important;
@@ -92,7 +87,6 @@ code svg{
 svg[id^="mermaid-"]
 {
     min-width: 100%;
-    //min-height: 700px;
 }
 .reveal .slide-menu-button
 {
diff --git a/docs/_sass/swagger-ui.scss b/docs/_sass/swagger-ui.scss
@@ -43,7 +43,7 @@
   overflow: visible;
 }
 .swagger-ui pre {
-  font-family: monospace, monospace;
+  font-family: monospace;
   font-size: 1em;
 }
 .swagger-ui a {
@@ -52,7 +52,6 @@
 }
 .swagger-ui abbr[title] {
   border-bottom: none;
-  text-decoration: underline;
   -webkit-text-decoration: underline dotted;
   text-decoration: underline dotted;
 }
@@ -64,7 +63,7 @@
 .swagger-ui code,
 .swagger-ui kbd,
 .swagger-ui samp {
-  font-family: monospace, monospace;
+  font-family: monospace;
   font-size: 1em;
 }
 .swagger-ui dfn {
@@ -100,6 +99,7 @@
 }
 .swagger-ui img {
   border-style: none;
+  max-width: 100%;
 }
 .swagger-ui svg:not(:root) {
   overflow: hidden;
@@ -108,12 +108,6 @@
 .swagger-ui input,
 .swagger-ui optgroup,
 .swagger-ui select,
-.swagger-ui textarea {
-  font-family: sans-serif;
-  font-size: 100%;
-  line-height: 1.15;
-  margin: 0;
-}
 .swagger-ui button,
 .swagger-ui input {
   overflow: visible;
@@ -156,9 +150,6 @@
   display: inline-block;
   vertical-align: baseline;
 }
-.swagger-ui textarea {
-  overflow: auto;
-}
 .swagger-ui [type="checkbox"],
 .swagger-ui [type="radio"] {
   box-sizing: border-box;
@@ -458,9 +449,6 @@
     z-index: 100;
   }
 }
-.swagger-ui img {
-  max-width: 100%;
-}
 .swagger-ui .cover {
   background-size: cover !important;
 }
@@ -1308,9 +1296,10 @@
   }
 }
 .swagger-ui .pre {
+  overflow: scroll;
   overflow-x: auto;
   overflow-y: hidden;
-  overflow: scroll;
+  white-space: pre;
 }
 .swagger-ui .top-0 {
   top: 0;
@@ -6857,9 +6846,6 @@
 .swagger-ui .nowrap {
   white-space: nowrap;
 }
-.swagger-ui .pre {
-  white-space: pre;
-}
 @media screen and (min-width: 30em) {
   .swagger-ui .ws-normal-ns {
     white-space: normal;
@@ -7143,16 +7129,14 @@
   display: flex;
   padding: 10px 20px 10px 10px;
   transition: all 0.2s;
-}
-.swagger-ui .opblock-tag:hover {
-  background: rgba(0, 0, 0, 0.02);
-}
-.swagger-ui .opblock-tag {
   color: #3b4151;
   font-family: sans-serif;
   font-size: 24px;
   margin: 0 0 5px;
 }
+.swagger-ui .opblock-tag:hover {
+  background: rgba(0, 0, 0, 0.02);
+}
 .swagger-ui .opblock-tag.no-desc span {
   flex: 1;
 }
@@ -7610,6 +7594,7 @@
   font-size: 14px;
   max-width: 40em;
   padding-left: 2em;
+  min-width: 6em;
 }
 .swagger-ui .response-col_links .response-undocumented {
   color: #909090;
@@ -8061,12 +8046,21 @@
 .swagger-ui input[type="search"],
 .swagger-ui input[type="text"],
 .swagger-ui textarea {
+  overflow: auto;
+  font-family: monospace;
+  font-size: 12px;
+  font-weight: 600;
+  line-height: 1.15;
   background: #fff;
   border: 1px solid #d9d9d9;
   border-radius: 4px;
-  margin: 5px 0;
+  color: #3b4151;
+  min-height: 280px;
   min-width: 100px;
+  outline: none;
   padding: 8px 10px;
+  width: 100%;
+  margin: 5px 0;
 }
 .swagger-ui input[type="email"].invalid,
 .swagger-ui input[type="file"].invalid,
@@ -8131,19 +8125,6 @@
     transform: translate3d(4px, 0, 0);
   }
 }
-.swagger-ui textarea {
-  background: hsla(0, 0%, 100%, 0.8);
-  border: none;
-  border-radius: 4px;
-  color: #3b4151;
-  font-family: monospace;
-  font-size: 12px;
-  font-weight: 600;
-  min-height: 280px;
-  outline: none;
-  padding: 10px;
-  width: 100%;
-}
 .swagger-ui textarea:focus {
   border: 2px solid #61affe;
 }
@@ -8318,9 +8299,6 @@
   position: absolute;
   top: -0.4em;
 }
-.swagger-ui .model-title {
-  position: relative;
-}
 .swagger-ui .model-title:hover .model-hint {
   visibility: visible;
 }
@@ -8454,6 +8432,7 @@
   color: #505050;
   font-family: sans-serif;
   font-size: 16px;
+  position: relative;
 }
 .swagger-ui .model-title img {
   bottom: 0;
@@ -8637,9 +8616,6 @@
 .swagger-ui .response-col_description {
   width: 99%;
 }
-.swagger-ui .response-col_links {
-  min-width: 6em;
-}
 .swagger-ui .response__extension {
   color: gray;
   font-family: monospace;
diff --git a/docs/assets/js/nhs-notify.js b/docs/assets/js/nhs-notify.js
@@ -1,9 +1,9 @@
 // Quick poc for view full screen
 
 window.addEventListener("load", (event) => {
-  var fullScreenParamName = "fullscreen";
-  var urlParams = new URLSearchParams(document.location.search);
-  var param = urlParams.get(fullScreenParamName);
+  let fullScreenParamName = "fullscreen";
+  let urlParams = new URLSearchParams(document.location.search);
+  let param = urlParams.get(fullScreenParamName);
   if (param) {
     tempViewFullScreen();
   } else {
@@ -14,7 +14,7 @@ window.addEventListener("load", (event) => {
 let nhsNotify = nhsNotifyDefaults();
 
 function nhsNotifyDefaults() {
-  var defaults = {};
+  let defaults = {};
   defaults.storageName = "cb-checked";
   defaults.buttonName = "fullScreenButton";
   defaults.standard = "Standard";
@@ -24,16 +24,16 @@ function nhsNotifyDefaults() {
 
 function tempViewFullScreen() {
   viewFullScreen();
-  var buttons = document.getElementsByName(nhsNotify.buttonName);
+  let buttons = document.getElementsByName(nhsNotify.buttonName);
   buttons.forEach((item) => {
     item.style.display = "none";
   });
 }
 
 function viewFullScreen() {
-  var sideBar = document.getElementsByClassName("side-bar")[0];
-  var main = document.getElementsByClassName("main")[0];
-  var pageInfo = document.getElementsByClassName("page-info")[0];
+  let sideBar = document.getElementsByClassName("side-bar")[0];
+  let main = document.getElementsByClassName("main")[0];
+  let pageInfo = document.getElementsByClassName("page-info")[0];
   sideBar.style.display = "none";
   main.style.maxWidth = "100%";
   main.style.marginLeft = "0px";
@@ -45,9 +45,9 @@ function setFullScreen() {
 }
 
 function setStandard() {
-  var sideBar = document.getElementsByClassName("side-bar")[0];
-  var main = document.getElementsByClassName("main")[0];
-  var pageInfo = document.getElementsByClassName("page-info")[0];
+  let sideBar = document.getElementsByClassName("side-bar")[0];
+  let main = document.getElementsByClassName("main")[0];
+  let pageInfo = document.getElementsByClassName("page-info")[0];
   sideBar.style.display = "";
   main.style.maxWidth = "";
   main.style.marginLeft = "";
@@ -56,7 +56,7 @@ function setStandard() {
 }
 
 function setViewAtStart() {
-  var currentStatus = localStorage.getItem(nhsNotify.storageName);
+  let currentStatus = localStorage.getItem(nhsNotify.storageName);
   if (currentStatus == nhsNotify.fullScreen) makeChange(currentStatus);
 }
 
@@ -69,9 +69,9 @@ function makeChange(newStatus) {
 }
 
 function afterChange(currentStatus, newStatus) {
-  var storageName = nhsNotify.storageName;
-  var buttonName = nhsNotify.buttonName;
-  var buttons = document.getElementsByName(buttonName);
+  let storageName = nhsNotify.storageName;
+  let buttonName = nhsNotify.buttonName;
+  let buttons = document.getElementsByName(buttonName);
   localStorage.setItem(storageName, newStatus);
 
   buttons.forEach((item) => {
@@ -80,29 +80,24 @@ function afterChange(currentStatus, newStatus) {
 }
 
 function fullScreenToggle() {
-  var standard = nhsNotify.standard;
-  var fullScreen = nhsNotify.fullScreen;
-  var storageName = nhsNotify.storageName;
-  var currentStatus = "";
-  var newStatus = "";
+  let standard = nhsNotify.standard;
+  let fullScreen = nhsNotify.fullScreen;
+  let storageName = nhsNotify.storageName;
+  let currentStatus;
+  let newStatus;
 
   currentStatus = localStorage.getItem(storageName);
 
   if (
     currentStatus == "false" ||
     currentStatus == "undefined" ||
-    currentStatus == null
+    currentStatus == null ||
+    currentStatus == standard
   ) {
-    currentStatus = standard;
     newStatus = fullScreen;
   }
-
-  if (currentStatus == standard) {
-    newStatus = fullScreen;
-    currentStatus = standard;
-  } else {
+  else {
     newStatus = standard;
-    currentStatus = fullScreen;
   }
 
   makeChange(newStatus);
diff --git a/docs/src/index.js b/docs/src/index.js

Original file line number	Diff line number	Diff line change
`@@ -32,13 +32,10 @@ section > h2 {`
`32`	`32`	`.site-fork-warning {`
`33`	`33`	`width: 100%;`
`34`	`34`	`padding-left: 30px;`
	`35`	`+ display: none;`
`35`	`36`	`@include mq(lg) {`
`36`	`37`	`width: $nav-width;`
`37`	`38`	`}`
`38`		`-}`
`39`		`-`
`40`		`-.site-fork-warning {`
`41`		`- display: none;`
`42`	`39`	`@include mq(md) {`
`43`	`40`	`display: block;`
`44`	`41`	`}`
`@@ -78,8 +75,6 @@ $base-button-color: $grey-nhs-pale-grey;`
`78`	`75`	`$nav-child-link-color: $grey-nhs-mid-grey;`
`79`	`76`	`$body-heading-color: $blue-nhs-dark-blue;`
`80`	`77`
`81`		`-//$body-font-family: Frutiger, Arial;`
`82`		`-`
`83`	`78`
`84`	`79`	`.text-nhs-mid-grey {`
`85`	`80`	`color: $grey-nhs-mid-grey !important;`
`@@ -92,7 +87,6 @@ code svg{`
`92`	`87`	`svg[id^="mermaid-"]`
`93`	`88`	`{`
`94`	`89`	`min-width: 100%;`
`95`		`- //min-height: 700px;`
`96`	`90`	`}`
`97`	`91`	`.reveal .slide-menu-button`
`98`	`92`	`{`