Skip to content

Commit 9e32282

Browse files
committed
Code review fixes
1 parent b350219 commit 9e32282

10 files changed

Lines changed: 202 additions & 155 deletions

File tree

README.md

Lines changed: 24 additions & 34 deletions
Large diffs are not rendered by default.

docs/collections/_events/mesh-status-report-sent.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

docs/collections/_events/queue-item-enqueued.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ schema_envelope: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025
77
schema_data: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-queue-item-enqueued-data.schema.json
88
---
99

10-
This event indicates that a TTL record has been queued for a given letter. The TTL record will either be intentionally removed before its expiry if the letter is read digitally (indicated by an ItemRemoved event) or will be dequeued after the fallback wait time (indicated by a QueueItemDequeued event) to trigger printing.
10+
This event indicates that a TTL record has been queued for a given letter. The TTL record will either be intentionally removed before its expiry if the letter is read digitally (indicated by an ItemRemoved event) or will be dequeued after the fallback wait time (indicated by a ItemDequeued event) to trigger printing.

docs/collections/_events/reporting-generate-report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
title: reporting-daily-generate-report
2+
title: reporting-generate-report
33
nice_name: GenerateReport
44
service: Reporting
55
type: uk.nhs.notify.digital.letters.reporting.generate.report.v1

docs/collections/_events/reporting-report-timer-expired.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

package-lock.json

Lines changed: 126 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/cloudevents/domains/digital-letters/2025-10-draft/data/digital-letter-base-data.schema.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ type: object
55
additionalProperties: false
66
properties:
77
something:
8-
$ref: ../defs/someobject.schema.yaml#/properties/something
8+
$ref: ../defs/some.object.schema.yaml#/properties/something
99
required:
1010
- something

src/cloudevents/domains/digital-letters/2025-10-draft/defs/someobject.schema.yaml renamed to src/cloudevents/domains/digital-letters/2025-10-draft/defs/some.object.schema.yaml

File renamed without changes.

0 commit comments

Comments
 (0)