Skip to content

Commit 87f0dca

Browse files
CCM-15019: Address review comments
1 parent 1997736 commit 87f0dca

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

lambdas/print-status-handler/src/__tests__/apis/sqs-handler.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ describe('SQS Handler', () => {
4141
id: '550e8400-e29b-41d4-a716-446655440001',
4242
time: '2023-06-20T12:00:00.250Z',
4343
recordedtime: '2023-06-20T12:00:00.250Z',
44+
plane: 'data',
4445
dataschema:
4546
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-letter-transitioned-data.schema.json',
4647
type: 'uk.nhs.notify.digital.letters.print.letter.transitioned.v1',

lambdas/report-scheduler/src/__tests__/apis/scheduled-event-handler.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,8 @@ describe('scheduled-event-handler', () => {
108108
);
109109
expect(event.time).toBe('2024-01-15T12:00:00.000Z');
110110
expect(event.severitynumber).toBe(2);
111+
expect(event.dataschema).toBe('https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-reporting-generate-report-data.schema.json')
112+
expect(event.dataschemaversion).toBe('1.0.0');
111113
expect(event.datacontenttype).toBe('application/json');
112114

113115
expect(() => validateGenerateReport(event, mockLogger)).not.toThrow();

utils/py-utils/dl_utils/__tests__/test_event_publisher.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ def valid_cloud_event():
4545
'id': '550e8400-e29b-41d4-a716-446655440001',
4646
'specversion': '1.0',
4747
'plane': 'data',
48-
'dataschemaversion': '1.0.0',
4948
'source': '/nhs/england/notify/production/primary/digitalletters/mesh',
5049
'subject': 'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
5150
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
@@ -72,7 +71,6 @@ def valid_cloud_event2():
7271
'id': '550e8400-e29b-41d4-a716-446655440002',
7372
'specversion': '1.0',
7473
'plane': 'data',
75-
'dataschemaversion': '1.0.0',
7674
'source': '/nhs/england/notify/development/primary/digitalletters/mesh',
7775
'subject': 'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
7876
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',

0 commit comments

Comments
 (0)