CCM-12616: More test fixing

Author: simonlabarere

tests/playwright/config/component/senders.setup.ts

@@ -1,19 +1,9 @@
 import { test as setup } from '@playwright/test';
+import { TEST_SENDERS } from 'constants/test-senders';
 import senderRepository from 'helpers/sender-helpers';
-import { Sender } from 'utils';
-
-const testSenders: Sender[] = [
-  {
-    senderId: 'test-sender-1',
-    senderName: 'Test Sender 1',
-    meshMailboxSenderId: 'test-mesh-sender-1',
-    meshMailboxReportsId: 'test-mesh-reports-1',
-    fallbackWaitTimeSeconds: 24 * 3600,
-  },
-];
 
 setup('Create senders', async () => {
-  for (const sender of testSenders) {
+  for (const sender of TEST_SENDERS) {
     await senderRepository.putSender(sender);
   }
 });

tests/playwright/constants/test-senders.ts

@@ -0,0 +1,11 @@
+import { Sender } from 'utils';
+
+export const TEST_SENDERS: Sender[] = [
+  {
+    senderId: '72c58534-d07a-409f-8a45-53b677b0ffd0',
+    senderName: 'Test Sender 1',
+    meshMailboxSenderId: 'test-mesh-sender-1',
+    meshMailboxReportsId: 'test-mesh-reports-1',
+    fallbackWaitTimeSeconds: 24 * 3600,
+  },
+];

tests/playwright/digital-letters-component-tests/mesh-poll-download.component.spec.ts

@@ -14,9 +14,10 @@ import { downloadFromS3, uploadToS3 } from 'helpers/s3-helpers';
 import { expectMessageContainingString } from 'helpers/sqs-helpers';
 import { v4 as uuidv4 } from 'uuid';
 import messageMessageReceived from 'digital-letters-events/MESHInboxMessageReceived.js';
+import { TEST_SENDERS } from 'constants/test-senders';
 
 test.describe('Digital Letters - MESH Poll and Download', () => {
-  const senderId = 'test-sender-1';
+  const { senderId } = TEST_SENDERS[0];
   const sendersMeshMailboxId = 'test-mesh-sender-1';
   const meshMailboxId = 'mock-mailbox';
 

tests/playwright/digital-letters-component-tests/pdm-uploader.component.spec.ts

@@ -12,6 +12,7 @@ import expectToPassEventually from 'helpers/expectations';
 import { uploadToS3 } from 'helpers/s3-helpers';
 import { expectMessageContainingString, purgeQueue } from 'helpers/sqs-helpers';
 import { v4 as uuidv4 } from 'uuid';
+import { TEST_SENDERS } from 'constants/test-senders';
 
 const pdmRequest = {
   resourceType: 'DocumentReference',
@@ -62,7 +63,7 @@ test.describe('Digital Letters - Upload to PDM', () => {
     const resourceKey = `test/${letterId}`;
     const messageUri = `s3://${LETTERS_S3_BUCKET_NAME}/${resourceKey}`;
     const messageReference = uuidv4();
-    const senderId = 'test-sender-1';
+    const { senderId } = TEST_SENDERS[0];
 
     uploadToS3(JSON.stringify(pdmRequest), LETTERS_S3_BUCKET_NAME, resourceKey);
 
@@ -114,7 +115,7 @@ test.describe('Digital Letters - Upload to PDM', () => {
     const resourceKey = `test/${letterId}`;
     const messageUri = `s3://${LETTERS_S3_BUCKET_NAME}/${resourceKey}`;
     const messageReference = uuidv4();
-    const senderId = 'test-sender-1';
+    const { senderId } = TEST_SENDERS[0];
     const invalidPdmRequest = {
       ...pdmRequest,
       unexpectedField: 'I should not be here',
@@ -174,7 +175,7 @@ test.describe('Digital Letters - Upload to PDM', () => {
     const eventId = uuidv4();
     const messageUri = `not-a-valid-s3-uri`;
     const messageReference = uuidv4();
-    const senderId = 'test-sender-1';
+    const { senderId } = TEST_SENDERS[0];
 
     await eventPublisher.sendEvents(
       [

tests/playwright/digital-letters-component-tests/ttl-create.component.spec.ts

@@ -7,6 +7,7 @@ import { getTtl } from 'helpers/dynamodb-helpers';
 import eventPublisher from 'helpers/event-bus-helpers';
 import expectToPassEventually from 'helpers/expectations';
 import { v4 as uuidv4 } from 'uuid';
+import { TEST_SENDERS } from 'constants/test-senders';
 
 test.describe('Digital Letters - Create TTL', () => {
   test('should create TTL and publish item enqueued event following message downloaded event', async () => {
@@ -35,7 +36,7 @@ test.describe('Digital Letters - Create TTL', () => {
           data: {
             messageUri,
             messageReference: 'ref1',
-            senderId: 'test-sender-1',
+            senderId: TEST_SENDERS[0].senderId,
           },
         },
       ],