CCM-13303: Address review comments

Author: simonlabarere

infrastructure/terraform/components/dl/module_lambda_core_notifier.tf

@@ -56,7 +56,7 @@ data "aws_iam_policy_document" "core_notifier_lambda" {
 
     resources = [
       "arn:aws:ssm:${var.region}:${var.aws_account_id}:parameter/${var.component}/${var.environment}/apim/*",
-      "arn:aws:ssm:${var.region}:${var.aws_account_id}:parameter/${var.component}/${var.environment}/senders/*"
+      "arn:aws:ssm:${var.region}:${var.aws_account_id}:parameter/${local.ssm_senders_prefix}/*"
     ]
   }
 

infrastructure/terraform/components/dl/module_lambda_ttl_create.tf

@@ -125,7 +125,7 @@ data "aws_iam_policy_document" "ttl_create_lambda" {
     ]
 
     resources = [
-      "arn:aws:ssm:${var.region}:${var.aws_account_id}:parameter/${var.component}/${var.environment}/senders/*"
+      "arn:aws:ssm:${var.region}:${var.aws_account_id}:parameter/${local.ssm_senders_prefix}/*"
     ]
   }
 }

lambdas/report-scheduler/package.json

@@ -2,7 +2,6 @@
   "dependencies": {
     "aws-lambda": "^1.0.7",
     "digital-letters-events": "^0.0.1",
-    "p-limit": "^3.1.0",
     "sender-management": "^0.0.1",
     "utils": "^0.0.1"
   },