CCM-14566: Fix tests following merge + use latest onboarding library

Author: simonlabarere

lambdas/mesh-download/mesh_download/__tests__/test_processor.py

@@ -198,8 +198,8 @@ def test_process_sqs_message_success(self, mock_datetime):
         mesh_message.read.assert_called_once()
 
         document_store.store_document.assert_called_once_with(
-            sender_id='TEST_SENDER',
-            message_reference='ref_001',
+            sender_id='TEST-SENDER',
+            message_reference='ref-001',
             mesh_message_id='test-message-123',
             content=create_fhir_content()
         )
@@ -254,6 +254,7 @@ def test_process_sqs_message_invalid_fhir_content(self, mock_datetime):
             log=log,
             mesh_client=config.mesh_client,
             download_metric=config.download_metric,
+            duplicate_download_metric=config.duplicate_download_metric,
             document_store=document_store,
             event_publisher=event_publisher
         )
@@ -266,7 +267,7 @@ def test_process_sqs_message_invalid_fhir_content(self, mock_datetime):
 
         processor.process_sqs_message(sqs_record)
 
-        config.mesh_client.retrieve_message.assert_called_once_with('test_message_123')
+        config.mesh_client.retrieve_message.assert_called_once_with('test-message-123')
 
         mesh_message.read.assert_called_once()
 
@@ -299,9 +300,9 @@ def test_process_sqs_message_invalid_fhir_content(self, mock_datetime):
 
         # Verify CloudEvent data payload
         event_data = published_event['data']
-        assert event_data['senderId'] == 'TEST_SENDER'
-        assert event_data['messageReference'] == 'ref_001'
-        assert event_data['meshMessageId'] == 'test_message_123'
+        assert event_data['senderId'] == 'TEST-SENDER'
+        assert event_data['messageReference'] == 'ref-001'
+        assert event_data['meshMessageId'] == 'test-message-123'
         assert event_data['failureCode'] == 'DL_CLIV_005'
         assert set(event_data.keys()) == {'senderId', 'messageReference', 'meshMessageId', 'failureCode'}
 

lambdas/mesh-download/requirements.txt

@@ -8,7 +8,7 @@ urllib3>=1.26.19,<2.0.0
 idna>=3.7
 requests>=2.32.0
 pyopenssl>=24.2.1
-nhs-notify-digital-letters-onboarding @ git+https://github.com/NHSDigital/nhs-notify-digital-letters-onboarding@75362ff36814a0b355f95ad8b6834e400c49c161
+nhs-notify-digital-letters-onboarding @ git+https://github.com/NHSDigital/nhs-notify-digital-letters-onboarding@cc12e80ee21573e49e497413cb68191763432917
 -e ../../src/digital-letters-events
 -e ../../utils/py-mock-mesh
 -e ../../utils/py-utils