Skip to content

Commit 6bf9123

Browse files
CCM-15019: adding dataschemaversion
1 parent 6872cce commit 6bf9123

40 files changed

Lines changed: 61 additions & 1 deletion

File tree

lambdas/core-notifier-lambda/src/__tests__/constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export const mockResponse: SingleMessageResponse = {
6161
export const validPdmEvent: PDMResourceAvailable = {
6262
id: 'event-id-123',
6363
plane: 'data',
64+
dataschemaversion: '1.0',
6465
source: '/nhs/england/notify/development/dev-12345/digitalletters/pdm',
6566
specversion: '1.0',
6667
type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',

lambdas/core-notifier-lambda/src/__tests__/domain/mapper.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ describe('mapper', () => {
2929
id: 'event-123',
3030
source: 'pdm-service',
3131
plane: 'data',
32+
dataschemaversion: '1.0',
3233
subject: 'resource/available',
3334
type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
3435
time: '2024-01-15T10:30:00Z',

lambdas/file-scanner-lambda/src/__tests__/apis/sqs-handler.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ const createValidItemDequeuedBody = (
4343
specversion: '1.0',
4444
id: `event-${messageReference}`,
4545
plane: 'data',
46+
dataschemaversion: '1.0',
4647
source: '/nhs/england/notify/development/primary/digitalletters/queue',
4748
subject: `message/${messageReference}`,
4849
type: 'uk.nhs.notify.digital.letters.queue.item.dequeued.v1',

lambdas/mesh-acknowledge/mesh_acknowledge/__tests__/test_events.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ def create_invalid_sqs_record(event_id: str) -> Dict[str, str]:
7373
),
7474
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
7575
'plane': 'data',
76+
'dataschemaversion': '1.0',
7677
'time': '2026-01-08T10:00:00Z',
7778
'recordedtime': '2026-01-08T10:00:00Z',
7879
'severitynumber': 2,
@@ -157,6 +158,7 @@ def test_publish_success(
157158
'recordedtime': fixed_time.isoformat(),
158159
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.acknowledged.v1',
159160
'plane': 'data',
161+
'dataschemaversion': '1.0',
160162
'dataschema': (
161163
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/'
162164
'digital-letters-mesh-inbox-message-acknowledged-data.schema.json'

lambdas/mesh-acknowledge/mesh_acknowledge/events.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ def publish_acknowledged_event(
5252
'recordedtime': now,
5353
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.acknowledged.v1',
5454
'plane': 'data',
55+
'dataschemaversion': '1.0',
5556
'dataschema': (
5657
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/'
5758
'digital-letters-mesh-inbox-message-acknowledged-data.schema.json'

lambdas/mesh-download/mesh_download/__tests__/test_processor.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def create_valid_cloud_event():
4242
'subject': 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000',
4343
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
4444
'plane': 'data',
45+
'dataschemaversion': '1.0',
4546
'time': '2023-01-01T12:00:00Z',
4647
'recordedtime': '2023-01-01T12:00:00Z',
4748
'severitynumber': 2,
@@ -164,6 +165,7 @@ def test_process_sqs_message_success(self, mock_datetime):
164165
assert published_event['subject'] == 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000'
165166
assert published_event['time'] == '2025-11-19T15:30:45+00:00'
166167
assert published_event['plane'] == 'data'
168+
assert published_event['dataschemaversion'] == '1.0'
167169
assert 'id' in published_event
168170
assert 'tracestate' not in published_event
169171
assert 'partitionkey' not in published_event

lambdas/mesh-download/mesh_download/processor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ def _publish_downloaded_event(self, incoming_event, message_uri):
116116
'recordedtime': now,
117117
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
118118
'plane': 'data',
119+
'dataschemaversion': '1.0',
119120
'dataschema': (
120121
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/'
121122
'digital-letters-mesh-inbox-message-downloaded-data.schema.json'

lambdas/mesh-poll/mesh_poll/processor.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ def _publish_mesh_inbox_message_received_event(self, event_detail):
163163
),
164164
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
165165
'plane': 'data',
166+
'dataschemaversion': '1.0',
166167
'time': now,
167168
'recordedtime': now,
168169
'severitynumber': 2,
@@ -200,6 +201,7 @@ def _publish_mesh_inbox_message_invalid_event(self, event_detail):
200201
'subject': f'customer/{event_detail["data"]["senderId"]}',
201202
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.invalid.v1',
202203
'plane': 'data',
204+
'dataschemaversion': '1.0',
203205
'time': now,
204206
'recordedtime': now,
205207
'severitynumber': 3,

lambdas/move-scanned-files-lambda/src/__tests__/apis/sqs-handler.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ describe('sqs-handler', () => {
6969
id: 'test-id',
7070
source: '/test',
7171
plane: 'data',
72+
dataschemaversion: '1.0',
7273
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
7374
time: '2024-01-01T00:00:00Z',
7475
data: {
@@ -109,6 +110,7 @@ describe('sqs-handler', () => {
109110
id: 'test-id-1',
110111
source: '/test',
111112
plane: 'data',
113+
dataschemaversion: '1.0',
112114
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
113115
time: '2024-01-01T00:00:00Z',
114116
data: {
@@ -128,6 +130,7 @@ describe('sqs-handler', () => {
128130
id: 'test-id-2',
129131
source: '/test',
130132
plane: 'data',
133+
dataschemaversion: '1.0',
131134
type: 'uk.nhs.notify.digital.letters.print.file.quarantined.v1',
132135
time: '2024-01-01T00:00:00Z',
133136
data: {
@@ -194,6 +197,7 @@ describe('sqs-handler', () => {
194197
id: 'test-id',
195198
source: '/test',
196199
plane: 'data',
200+
dataschemaversion: '1.0',
197201
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
198202
time: '2024-01-01T00:00:00Z',
199203
data: {

lambdas/move-scanned-files-lambda/src/__tests__/domain/mapper.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ describe('mapper', () => {
4545
subject: `customer/${senderId}/recipient/${messageReference}`,
4646
source: '/nhs/england/notify/production/primary/digitalletters/print',
4747
plane: 'data',
48+
dataschemaversion: '1.0',
4849
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
4950
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
5051
time: '2024-01-15T10:30:00.000Z',
@@ -100,6 +101,7 @@ describe('mapper', () => {
100101
id: 'mocked-uuid-12345',
101102
subject: `customer/${senderId}/recipient/${messageReference}`,
102103
plane: 'data',
104+
dataschemaversion: '1.0',
103105
source: '/nhs/england/notify/production/primary/digitalletters/print',
104106
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
105107
type: 'uk.nhs.notify.digital.letters.print.file.quarantined.v1',

0 commit comments

Comments
 (0)