Skip to content

Commit 6469c22

Browse files
CCM-15019: adding plane: data
1 parent 12012c7 commit 6469c22

82 files changed

Lines changed: 154 additions & 121 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

lambdas/core-notifier-lambda/src/__tests__/constants.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ export const mockResponse: SingleMessageResponse = {
6060

6161
export const validPdmEvent: PDMResourceAvailable = {
6262
id: 'event-id-123',
63-
source:
64-
'/nhs/england/notify/development/dev-12345/data-plane/digitalletters/pdm',
63+
plane: 'data',
64+
source: '/nhs/england/notify/development/dev-12345/digitalletters/pdm',
6565
specversion: '1.0',
6666
type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
6767
time: '2025-12-15T10:00:00Z',

lambdas/core-notifier-lambda/src/__tests__/domain/mapper.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ describe('mapper', () => {
2828
specversion: '1.0',
2929
id: 'event-123',
3030
source: 'pdm-service',
31+
plane: 'data',
3132
subject: 'resource/available',
3233
type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
3334
time: '2024-01-15T10:30:00Z',

lambdas/file-scanner-lambda/src/__tests__/apis/sqs-handler.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ const createValidItemDequeuedBody = (
4242
detail: {
4343
specversion: '1.0',
4444
id: `event-${messageReference}`,
45-
source:
46-
'/nhs/england/notify/development/primary/data-plane/digitalletters/queue',
45+
plane: 'data',
46+
source: '/nhs/england/notify/development/primary/digitalletters/queue',
4747
subject: `message/${messageReference}`,
4848
type: 'uk.nhs.notify.digital.letters.queue.item.dequeued.v1',
4949
time: '2026-01-19T12:00:00Z',
@@ -319,7 +319,7 @@ describe('SQS Handler', () => {
319319
specversion: '1.0',
320320
id: 'event-001',
321321
source:
322-
'/nhs/england/notify/development/primary/data-plane/digitalletters/queue',
322+
'/nhs/england/notify/development/primary/digitalletters/queue',
323323
type: 'uk.nhs.notify.wrong.event.type.v1',
324324
time: '2026-01-19T12:00:00Z',
325325
data: {
@@ -386,7 +386,7 @@ describe('SQS Handler', () => {
386386
specversion: '1.0',
387387
id: 'event-001',
388388
source:
389-
'/nhs/england/notify/development/primary/data-plane/digitalletters/queue',
389+
'/nhs/england/notify/development/primary/digitalletters/queue',
390390
type: 'uk.nhs.notify.digital.letters.queue.item.dequeued.v1',
391391
time: '2026-01-19T12:00:00Z',
392392
data: {

lambdas/mesh-acknowledge/mesh_acknowledge/__tests__/fixtures.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def create_downloaded_event_dict(event_id: str) -> Dict[str, str | int | Dict[st
99
"specversion": "1.0",
1010
"source": (
1111
"/nhs/england/notify/production/primary/"
12-
'data-plane/digitalletters/mesh'
12+
'digitalletters/mesh'
1313
),
1414
"subject": (
1515
'customer/920fca11-596a-4eca-9c47-99f624614658/'
@@ -18,6 +18,7 @@ def create_downloaded_event_dict(event_id: str) -> Dict[str, str | int | Dict[st
1818
"type": (
1919
'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1'
2020
),
21+
"plane": "data",
2122
"time": '2026-01-08T10:00:00Z',
2223
"recordedtime": '2026-01-08T10:00:00Z',
2324
"severitynumber": 2,

lambdas/mesh-acknowledge/mesh_acknowledge/__tests__/test_events.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,13 @@ def create_invalid_sqs_record(event_id: str) -> Dict[str, str]:
6666
'detail': {
6767
'id': event_id,
6868
'specversion': '1.0',
69-
'source': '/nhs/england/notify/production/primary/data-plane/digitalletters/mesh',
69+
'source': '/nhs/england/notify/production/primary/digitalletters/mesh',
7070
'subject': (
7171
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/'
7272
'769acdd4-6a47-496f-999f-76a6fd2c3959'
7373
),
7474
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
75+
'plane': 'data',
7576
'time': '2026-01-08T10:00:00Z',
7677
'recordedtime': '2026-01-08T10:00:00Z',
7778
'severitynumber': 2,
@@ -155,6 +156,7 @@ def test_publish_success(
155156
'time': fixed_time.isoformat(),
156157
'recordedtime': fixed_time.isoformat(),
157158
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.acknowledged.v1',
159+
'plane': 'data',
158160
'dataschema': (
159161
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/'
160162
'digital-letters-mesh-inbox-message-acknowledged-data.schema.json'

lambdas/mesh-acknowledge/mesh_acknowledge/events.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ def publish_acknowledged_event(
5151
'time': now,
5252
'recordedtime': now,
5353
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.acknowledged.v1',
54+
'plane': 'data',
5455
'dataschema': (
5556
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/'
5657
'digital-letters-mesh-inbox-message-acknowledged-data.schema.json'

lambdas/mesh-download/mesh_download/__tests__/test_processor.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@ def create_valid_cloud_event():
3838
return {
3939
'id': str(uuid4()),
4040
'specversion': '1.0',
41-
'source': '/nhs/england/notify/development/primary/data-plane/digitalletters/mesh',
41+
'source': '/nhs/england/notify/development/primary/digitalletters/mesh',
4242
'subject': 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000',
4343
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
44+
'plane': 'data',
4445
'time': '2023-01-01T12:00:00Z',
4546
'recordedtime': '2023-01-01T12:00:00Z',
4647
'severitynumber': 2,
@@ -159,9 +160,10 @@ def test_process_sqs_message_success(self, mock_datetime):
159160

160161
# Verify CloudEvent envelope fields
161162
assert published_event['type'] == 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1'
162-
assert published_event['source'] == '/nhs/england/notify/development/primary/data-plane/digitalletters/mesh'
163+
assert published_event['source'] == '/nhs/england/notify/development/primary/digitalletters/mesh'
163164
assert published_event['subject'] == 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000'
164165
assert published_event['time'] == '2025-11-19T15:30:45+00:00'
166+
assert published_event['plane'] == 'data'
165167
assert 'id' in published_event
166168
assert 'tracestate' not in published_event
167169
assert 'partitionkey' not in published_event

lambdas/mesh-download/mesh_download/processor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ def _publish_downloaded_event(self, incoming_event, message_uri):
115115
'time': now,
116116
'recordedtime': now,
117117
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
118+
'plane': 'data',
118119
'dataschema': (
119120
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/'
120121
'digital-letters-mesh-inbox-message-downloaded-data.schema.json'

lambdas/mesh-poll/mesh_poll/processor.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ def __init__(self, **kwargs):
3030

3131
environment = 'development'
3232
deployment = 'primary'
33-
plane = 'data-plane'
3433
self.__cloud_event_source = (
35-
f'/nhs/england/notify/{environment}/{deployment}/{plane}/'
34+
f'/nhs/england/notify/{environment}/{deployment}/'
3635
'digitalletters/mesh'
3736
)
3837

@@ -163,6 +162,7 @@ def _publish_mesh_inbox_message_received_event(self, event_detail):
163162
f'{event_detail["data"]["messageReference"]}'
164163
),
165164
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
165+
'plane': 'data',
166166
'time': now,
167167
'recordedtime': now,
168168
'severitynumber': 2,
@@ -199,6 +199,7 @@ def _publish_mesh_inbox_message_invalid_event(self, event_detail):
199199
'source': self.__cloud_event_source,
200200
'subject': f'customer/{event_detail["data"]["senderId"]}',
201201
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.invalid.v1',
202+
'plane': 'data',
202203
'time': now,
203204
'recordedtime': now,
204205
'severitynumber': 3,

lambdas/move-scanned-files-lambda/src/__tests__/apis/sqs-handler.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ describe('sqs-handler', () => {
6868
specversion: '1.0',
6969
id: 'test-id',
7070
source: '/test',
71+
plane: 'data',
7172
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
7273
time: '2024-01-01T00:00:00Z',
7374
data: {
@@ -107,6 +108,7 @@ describe('sqs-handler', () => {
107108
specversion: '1.0',
108109
id: 'test-id-1',
109110
source: '/test',
111+
plane: 'data',
110112
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
111113
time: '2024-01-01T00:00:00Z',
112114
data: {
@@ -125,6 +127,7 @@ describe('sqs-handler', () => {
125127
specversion: '1.0',
126128
id: 'test-id-2',
127129
source: '/test',
130+
plane: 'data',
128131
type: 'uk.nhs.notify.digital.letters.print.file.quarantined.v1',
129132
time: '2024-01-01T00:00:00Z',
130133
data: {
@@ -190,6 +193,7 @@ describe('sqs-handler', () => {
190193
specversion: '1.0',
191194
id: 'test-id',
192195
source: '/test',
196+
plane: 'data',
193197
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
194198
time: '2024-01-01T00:00:00Z',
195199
data: {

0 commit comments

Comments
 (0)