CCM-13303: Address comments + update Generate Report schema

Author: simonlabarere

lambdas/report-scheduler/src/__tests__/apis/scheduled-event-handler.test.ts

@@ -121,19 +121,6 @@ describe('scheduled-event-handler', () => {
       expect(events).toHaveLength(0);
     });
 
-    it('should handle sender management errors', async () => {
-      const error = new Error('Failed to list senders');
-      mockSenderManagement.listSenders.mockRejectedValue(error);
-
-      const handler = createHandler({
-        senderManagement: mockSenderManagement,
-        eventPublisher: mockEventPublisher,
-      });
-
-      await expect(handler()).rejects.toThrow('Failed to list senders');
-      expect(mockEventPublisher.sendEvents).not.toHaveBeenCalled();
-    });
-
     it('should handle event publisher errors', async () => {
       const mockSenders = [{ senderId: 'sender-1' }] as unknown as Sender[];
       const error = new Error('Failed to publish events');

tests/playwright/digital-letters-component-tests/report-scheduler.component.spec.ts

@@ -3,7 +3,11 @@ import {
   EVENT_BUS_LOG_GROUP_NAME,
   REPORT_SCHEDULER_LAMBDA_NAME,
 } from 'constants/backend-constants';
-import { SENDER_ID_SKIPS_NOTIFY, SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX, SENDER_ID_VALID_FOR_NOTIFY_SANDBOX } from 'constants/tests-constants';
+import {
+  SENDER_ID_SKIPS_NOTIFY,
+  SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX,
+  SENDER_ID_VALID_FOR_NOTIFY_SANDBOX,
+} from 'constants/tests-constants';
 import { getLogsFromCloudwatch } from 'helpers/cloudwatch-helpers';
 import expectToPassEventually from 'helpers/expectations';
 import { invokeLambda } from 'helpers/lambda-helpers';
@@ -50,7 +54,9 @@ test.describe('Digital Letters - Report Scheduler', () => {
 
       const senderIds = parsedEvents.map((event) => event.data.senderId);
       expect(senderIds).toContain(SENDER_ID_VALID_FOR_NOTIFY_SANDBOX);
-      expect(senderIds).toContain(SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX);
+      expect(senderIds).toContain(
+        SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX,
+      );
       expect(senderIds).toContain(SENDER_ID_SKIPS_NOTIFY);
     }, 120);
   });