Skip to content

Commit 44f3682

Browse files
committed
CCM-12616: Adjust component test
1 parent 709cab7 commit 44f3682

2 files changed

Lines changed: 13 additions & 27 deletions

File tree

tests/playwright/digital-letters-component-tests/mesh-poll-download.component.spec.ts

Lines changed: 12 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { invokeLambda } from 'helpers/lambda-helpers';
1313
import { downloadFromS3, uploadToS3 } from 'helpers/s3-helpers';
1414
import { expectMessageContainingString } from 'helpers/sqs-helpers';
1515
import { v4 as uuidv4 } from 'uuid';
16+
import messageMessageReceived from 'digital-letters-events/MESHInboxMessageReceived.js';
1617

1718
test.describe('Digital Letters - MESH Poll and Download', () => {
1819
const senderId = 'test-sender-1';
@@ -37,23 +38,6 @@ test.describe('Digital Letters - MESH Poll and Download', () => {
3738
await uploadToS3(messageContent, NON_PII_S3_BUCKET_NAME, key, meshMetadata);
3839
}
3940

40-
async function uploadMeshMessageWithSender(
41-
meshMessageId: string,
42-
messageReference: string,
43-
messageContent: string,
44-
senderMailboxId: string,
45-
): Promise<void> {
46-
const key = `mock-mesh/${meshMailboxId}/in/${meshMessageId}`;
47-
const meshMetadata = {
48-
sender: senderMailboxId,
49-
subject: '201',
50-
workflow_id: 'NHS_NOTIFY_SEND_REQUEST',
51-
local_id: messageReference,
52-
};
53-
54-
await uploadToS3(messageContent, NON_PII_S3_BUCKET_NAME, key, meshMetadata);
55-
}
56-
5741
async function expectMeshInboxMessageReceivedEvent(
5842
meshMessageId: string,
5943
): Promise<void> {
@@ -105,9 +89,7 @@ test.describe('Digital Letters - MESH Poll and Download', () => {
10589
await invokeLambda(MESH_POLL_LAMBDA_NAME);
10690

10791
await expectMeshInboxMessageReceivedEvent(meshMessageId);
108-
await expectMeshInboxMessageDownloadedEvent(
109-
messageReference,
110-
);
92+
await expectMeshInboxMessageDownloadedEvent(messageReference);
11193

11294
await expectToPassEventually(async () => {
11395
const storedMessage = await downloadFromS3(
@@ -139,23 +121,27 @@ test.describe('Digital Letters - MESH Poll and Download', () => {
139121
{
140122
id: uuidv4(),
141123
specversion: '1.0',
142-
source: '/nhs/england/notify/development/primary/data-plane/digitalletters/mesh',
143-
subject: 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000',
124+
source:
125+
'/nhs/england/notify/development/primary/data-plane/digitalletters/mesh',
126+
subject:
127+
'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000',
144128
type: 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
145129
time: '2026-01-20T15:48:21.636284+00:00',
146130
recordedtime: '2026-01-20T15:48:21.636284+00:00',
147131
severitynumber: 2,
148132
severitytext: 'INFO',
149-
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
150-
dataschema: 'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-mesh-inbox-message-received-data.schema.json',
133+
traceparent:
134+
'00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
135+
dataschema:
136+
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-mesh-inbox-message-received-data.schema.json',
151137
data: {
152138
meshMessageId: invalidMeshMessageId,
153139
senderId,
154140
messageReference,
155141
},
156-
}
142+
},
157143
],
158-
() => true,
144+
messageMessageReceived,
159145
);
160146

161147
await expectMessageContainingString(

tests/playwright/digital-letters-component-tests/pdm-uploader.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ test.describe('Digital Letters - Upload to PDM', () => {
194194
},
195195
},
196196
],
197-
() => true,
197+
messageDownloadedValidator,
198198
);
199199

200200
await expectToPassEventually(async () => {

0 commit comments

Comments
 (0)