CCM-16553: Code review comments #2634
nhsd-angel-pastorcicd-1-pull-request.yaml
on: push
Set CI/CD metadata
4s
Commit stage
/
Scan secrets
17s
Commit stage
/
Check file format
8s
Commit stage
/
Check Markdown format
3s
Commit stage
/
Check English usage
7s
Commit stage
/
Check TODO usage
5s
Commit stage
/
Count lines of code
6s
Commit stage
/
Scan dependencies
53s
Commit stage
/
Run terraform-docs
9s
Commit stage
/
Lint Terraform
24s
Test stage
/
Contract tests
50s
Test stage
/
Linting
1m 40s
Test stage
/
Typecheck
2m 10s
Publish stage
/
Publish packages
Acceptance stage
/
Accessibility test
Acceptance stage
/
Integration test
Acceptance stage
/
Load test
Acceptance stage
/
Security test
Acceptance stage
/
UI performance test
Acceptance stage
/
UI test
Annotations
9 errors and 14 warnings
|
Test stage / Linting
Process completed with exit code 2.
|
|
Test stage / Linting
nhs-notify-digital-letters-scripts#lint: command (/home/runner/work/nhs-notify-digital-letters/nhs-notify-digital-letters/scripts) /opt/hostedtoolcache/node/24.10.0/x64/bin/npm run lint exited (1)
|
|
|
|
|
|
Test stage / Linting:
scripts/nft-event-generator/src/__tests__/destinations/send-events-to-event-bus.test.ts#L111
Replace `.mocked(EventBridgeClient)` with `⏎······.mocked(EventBridgeClient)⏎······`
|
|
Test stage / Linting:
scripts/nft-event-generator/src/__tests__/destinations/send-events-to-event-bus.test.ts#L76
Replace `⏎······new·Error('Something·went·wrong!'),⏎····` with `new·Error('Something·went·wrong!')`
|
|
|
|
|
|
Test stage / Linting:
scripts/nft-event-generator/src/__tests__/destinations/send-events-to-event-bus.test.ts#L41
Replace `.mocked(EventBridgeClient)` with `⏎······.mocked(EventBridgeClient)⏎······`
|
|
Test stage / Detect Schema Changes
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test stage / Contract tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test stage / Linting:
lambdas/print-analyser/src/__tests__/test-data.ts#L61
Found readFileSync from package "node:fs" with non literal argument at index 0
|
|
Test stage / Linting:
src/typescript-schema-generator/src/generate-types.ts#L34
Found writeFileSync from package "node:fs" with non literal argument at index 0
|
|
Test stage / Linting:
src/typescript-schema-generator/src/generate-guard-functions.ts#L51
Found writeFileSync from package "node:fs" with non literal argument at index 0
|
|
Test stage / Linting:
utils/utils/src/event-publisher/event-publisher.ts#L101
Function Call Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/event-publisher/event-publisher.ts#L99
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/dynamodb/delete-dynamo-batch.ts#L47
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/dynamodb/delete-dynamo-batch.ts#L34
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/config-reader.ts#L69
Variable Assigned to Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/cache/cache.ts#L52
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/cache/cache.ts#L33
Variable Assigned to Object Injection Sink
|
|
Test stage / Unit tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test stage / Perform static analysis
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
code-coverage-report
|
17 KB |
sha256:783ccec1be729a0bc3c7454ee263d0d5d0f78e8c82354f0169f3d75797f02f5f
|
|
|
lines-of-code-report.json.zip
|
982 Bytes |
sha256:554e1693d26f3108da27563d2b08b54719cc231d01aac9a6085b54b9be41cea1
|
|
|
pact-contracts
|
609 Bytes |
sha256:a3ed4851e86d85b41103c8f4570b5b198fcde52b1eb9c557ac8fc15aed3b0fc1
|
|
|
python-coverage-reports
|
13.4 KB |
sha256:6e04032f0b6b2f3a523937e898acb4012ec55242c06838a07825f7e27472286a
|
|
|
sbom-repository-report.json.zip
|
394 KB |
sha256:1baa4733d4c0db970ff8bbc3636dddad01c0df9bea712799920e1065490845ec
|
|
|
unit-tests
|
1.96 MB |
sha256:824d5076262a67416b79cbbd6a766eea51bd276a2100617a2cb9a0f819bc476a
|
|
|
vulnerabilities-repository-report.json.zip
|
18.3 KB |
sha256:5b30ed375396ea26081c4baf178e4728fe4db81f3460b62d29d8c9ba6a5c2381
|
|